Issue 416393002: Kraken recover after r20312.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 416393002: Kraken recover after r20312. (Closed)

Created:
6 years, 5 months ago by Igor Sheludko

Modified:
6 years, 5 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Total comments: 1

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -75 lines)			Patch
	M	src/elements.cc	View		21 chunks	+61 lines, -71 lines	0 comments	Download
	M	src/factory.h	View		1 chunk	+2 lines, -4 lines	1 comment	Download

Total messages: 3 (0 generated)

Igor Sheludko

PTAL. In elements.cc I turned functions that do not allocate back to raw-pointer form. For ...

6 years, 5 months ago (2014-07-25 12:42:49 UTC) #1

Igor Sheludko

6 years, 5 months ago (2014-07-25 13:00:13 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r22620 (presubmit successful).