Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1028)

Issue 212573007: ElementsAccessor::CopyElements() and its callers handlified. (Closed)

Created:
6 years, 9 months ago by Igor Sheludko
Modified:
6 years, 9 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

ElementsAccessor::CopyElements() and its callers handlified. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20312

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -242 lines) Patch
M src/builtins.cc View 10 chunks +49 lines, -56 lines 2 comments Download
M src/elements.h View 2 chunks +0 lines, -16 lines 0 comments Download
M src/elements.cc View 32 chunks +123 lines, -168 lines 0 comments Download
M src/factory.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/factory.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/objects.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/objects-inl.h View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Igor Sheludko
PTAL
6 years, 9 months ago (2014-03-26 15:29:25 UTC) #1
Yang
lgtm. https://codereview.chromium.org/212573007/diff/1/src/builtins.cc File src/builtins.cc (right): https://codereview.chromium.org/212573007/diff/1/src/builtins.cc#newcode778 src/builtins.cc:778: handle(result_array->elements()), 0, result_len, elms); CopyElements cannot throw, correct?
6 years, 9 months ago (2014-03-27 15:39:22 UTC) #2
Igor Sheludko
https://codereview.chromium.org/212573007/diff/1/src/builtins.cc File src/builtins.cc (right): https://codereview.chromium.org/212573007/diff/1/src/builtins.cc#newcode778 src/builtins.cc:778: handle(result_array->elements()), 0, result_len, elms); On 2014/03/27 15:39:22, Yang wrote: ...
6 years, 9 months ago (2014-03-27 16:00:09 UTC) #3
Yang
On 2014/03/27 16:00:09, Igor Sheludko wrote: > https://codereview.chromium.org/212573007/diff/1/src/builtins.cc > File src/builtins.cc (right): > > https://codereview.chromium.org/212573007/diff/1/src/builtins.cc#newcode778 ...
6 years, 9 months ago (2014-03-27 16:01:20 UTC) #4
Igor Sheludko
6 years, 9 months ago (2014-03-27 16:41:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r20312 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698