Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 415953005: Introduce NonJSProxyHolder returning Handle<JSObject> and return Handle<JSReceiver> for GetHolder (Closed)

Created:
6 years, 5 months ago by Toon Verwaest
Modified:
6 years, 5 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Introduce NonJSProxyHolder returning Handle<JSObject> and return Handle<JSReceiver> for GetHolder BUG= R=rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22594

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : Remove non-template version #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -38 lines) Patch
M src/lookup.h View 1 2 2 chunks +4 lines, -8 lines 0 comments Download
M src/lookup.cc View 1 7 chunks +10 lines, -9 lines 0 comments Download
M src/objects.cc View 1 11 chunks +22 lines, -21 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Toon Verwaest
PTAL
6 years, 5 months ago (2014-07-24 11:08:05 UTC) #1
rossberg
https://codereview.chromium.org/415953005/diff/1/src/lookup.h File src/lookup.h (right): https://codereview.chromium.org/415953005/diff/1/src/lookup.h#newcode100 src/lookup.h:100: Handle<JSObject> GetNonJSProxyHolder() const { You should call it GetJSObjectHolder. ...
6 years, 5 months ago (2014-07-24 11:18:33 UTC) #2
Toon Verwaest
PTAL again
6 years, 5 months ago (2014-07-24 11:25:47 UTC) #3
rossberg
lgtm
6 years, 5 months ago (2014-07-24 11:32:35 UTC) #4
Toon Verwaest
Committed patchset #3 manually as r22594 (presubmit successful).
6 years, 5 months ago (2014-07-24 11:33:54 UTC) #5
arv (Not doing code reviews)
6 years, 5 months ago (2014-07-24 17:01:54 UTC) #6
Message was sent while issue was closed.
LGTM

Thanks for fixing this.

Powered by Google App Engine
This is Rietveld 408576698