Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: src/lookup.h

Issue 415953005: Introduce NonJSProxyHolder returning Handle<JSObject> and return Handle<JSReceiver> for GetHolder (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Remove non-template version Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/lookup.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/lookup.h
diff --git a/src/lookup.h b/src/lookup.h
index c96a1e66e7b981aa04fec81797008e0c65ee075a..c96b2d11dd640d7044b635a29fcb4325f5ae672a 100644
--- a/src/lookup.h
+++ b/src/lookup.h
@@ -93,9 +93,10 @@ class LookupIterator V8_FINAL BASE_EMBEDDED {
return Handle<Object>::cast(maybe_receiver_.ToHandleChecked());
}
Handle<Map> holder_map() const { return holder_map_; }
- Handle<JSObject> GetHolder() const {
- ASSERT(IsFound() && state_ != JSPROXY);
- return Handle<JSObject>::cast(maybe_holder_.ToHandleChecked());
+ template <class T>
+ Handle<T> GetHolder() const {
+ ASSERT(IsFound());
+ return Handle<T>::cast(maybe_holder_.ToHandleChecked());
}
Handle<JSReceiver> GetRoot() const;
bool HolderIsReceiver() const;
@@ -141,11 +142,6 @@ class LookupIterator V8_FINAL BASE_EMBEDDED {
void InternalizeName();
- /* JSPROXY */
- Handle<JSProxy> GetJSProxy() const {
- return Handle<JSProxy>::cast(maybe_holder_.ToHandleChecked());
- }
-
private:
Handle<Map> GetReceiverMap() const;
« no previous file with comments | « no previous file | src/lookup.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698