Remove chrome::NOTIFICATION_PROFILE_DESTROYED usage from src/extensions

Remove chrome::NOTIFICATION_PROFILE_DESTROYED usage from src/extensions

The extensions module should not be listening to Chrome notifications.
Move the observation to ChromeProcessManagerDelegate.

BUG=396083
TEST=browser_tests ProcessManager* and unit_tests ProcessManager*

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285482

[James Cook, 2014-07-24 18:27:54]

yoz, PTAL

https://codereview.chromium.org/415933003/diff/60001/chrome/browser/extension...
File chrome/browser/extensions/chrome_process_manager_delegate.cc (right):

https://codereview.chromium.org/415933003/diff/60001/chrome/browser/extension...
chrome/browser/extensions/chrome_process_manager_delegate.cc:157: // If this
profile owns an incognito profile then close the incognito
This mimics the behavior of the existing code (specifically the part where an
incognito process manager was listening for PROFILE_DESTROYED for the original
non-incognito context.)

It's unclear to me why it's needed. I guess it's because a non-incognito profile
could be destroyed *before* the incognito profile that it owns? So we need to
shut down split-mode extensions before the incognito profile closes?

https://codereview.chromium.org/415933003/diff/60001/extensions/browser/proce...
File extensions/browser/process_manager.cc (right):

https://codereview.chromium.org/415933003/diff/60001/extensions/browser/proce...
extensions/browser/process_manager.cc:630: void
ProcessManager::CloseBackgroundHosts() {
Moved unchanged from below to match declaration order.

[Yoyo Zhou, 2014-07-24 20:25:01]

LGTM

https://codereview.chromium.org/415933003/diff/60001/chrome/browser/extension...
File chrome/browser/extensions/chrome_process_manager_delegate.cc (right):

https://codereview.chromium.org/415933003/diff/60001/chrome/browser/extension...
chrome/browser/extensions/chrome_process_manager_delegate.cc:157: // If this
profile owns an incognito profile then close the incognito
On 2014/07/24 18:27:54, James Cook wrote:
> This mimics the behavior of the existing code (specifically the part where an
> incognito process manager was listening for PROFILE_DESTROYED for the original
> non-incognito context.)
> 
> It's unclear to me why it's needed. I guess it's because a non-incognito
profile
> could be destroyed *before* the incognito profile that it owns? So we need to
> shut down split-mode extensions before the incognito profile closes?

From the CL that added this, I wrote

(which happens in a few tests)

so I think it only happens in test code. That can go into the comment here.

[James Cook, 2014-07-24 21:02:35]

https://codereview.chromium.org/415933003/diff/60001/chrome/browser/extension...
File chrome/browser/extensions/chrome_process_manager_delegate.cc (right):

https://codereview.chromium.org/415933003/diff/60001/chrome/browser/extension...
chrome/browser/extensions/chrome_process_manager_delegate.cc:157: // If this
profile owns an incognito profile then close the incognito
On 2014/07/24 20:25:01, Yoyo Zhou wrote:
> On 2014/07/24 18:27:54, James Cook wrote:
> > This mimics the behavior of the existing code (specifically the part where
an
> > incognito process manager was listening for PROFILE_DESTROYED for the
original
> > non-incognito context.)
> > 
> > It's unclear to me why it's needed. I guess it's because a non-incognito
> profile
> > could be destroyed *before* the incognito profile that it owns? So we need
to
> > shut down split-mode extensions before the incognito profile closes?
> 
> From the CL that added this, I wrote
> 
> (which happens in a few tests)
> 
> so I think it only happens in test code. That can go into the comment here.

Done.

[James Cook, 2014-07-24 21:02:40]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2014-07-24 21:06:18]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jamescook@chromium.org/415933003/80001

[commit-bot: I haz the power, 2014-07-25 01:18:55]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-07-25 05:24:44]

Change committed as 285482