Remove chrome::NOTIFICATION_PROFILE_DESTROYED usage from src/extensions

chrome/browser/extensions/chrome_process_manager_delegate.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/chrome_process_manager_delegate.h"
 
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chrome_notification_types.h"
@@ skipping 12 matching lines @@
 
 namespace extensions {
 
 ChromeProcessManagerDelegate::ChromeProcessManagerDelegate() {
   registrar_.Add(this,
                  chrome::NOTIFICATION_BROWSER_WINDOW_READY,
                  content::NotificationService::AllSources());
   registrar_.Add(this,
                  chrome::NOTIFICATION_PROFILE_CREATED,
                  content::NotificationService::AllSources());
-  // TODO(jamescook): Move observation of NOTIFICATION_PROFILE_DESTROYED here.
-  // http://crbug.com/392658
+  registrar_.Add(this,
+                 chrome::NOTIFICATION_PROFILE_DESTROYED,
+                 content::NotificationService::AllSources());
 }
 
 ChromeProcessManagerDelegate::~ChromeProcessManagerDelegate() {
 }
 
 bool ChromeProcessManagerDelegate::IsBackgroundPageAllowed(
     content::BrowserContext* context) const {
   Profile* profile = static_cast<Profile*>(context);
 
   // Disallow if the current session is a Guest mode session but the current
@@ skipping 33 matching lines @@
     case chrome::NOTIFICATION_BROWSER_WINDOW_READY: {
       Browser* browser = content::Source<Browser>(source).ptr();
       OnBrowserWindowReady(browser);
       break;
     }
     case chrome::NOTIFICATION_PROFILE_CREATED: {
       Profile* profile = content::Source<Profile>(source).ptr();
       OnProfileCreated(profile);
       break;
     }
-
+    case chrome::NOTIFICATION_PROFILE_DESTROYED: {
+      Profile* profile = content::Source<Profile>(source).ptr();
+      OnProfileDestroyed(profile);
+      break;
+    }
     default:
       NOTREACHED();
   }
 }
 
 void ChromeProcessManagerDelegate::OnBrowserWindowReady(Browser* browser) {
   Profile* profile = browser->profile();
   DCHECK(profile);
 
   // If the extension system isn't ready yet the background hosts will be
@@ skipping 34 matching lines @@
   ProcessManager* manager = ExtensionSystem::Get(profile)->process_manager();
   if (!manager)
     return;
 
   // The profile might have been initialized asynchronously (in parallel with
   // extension system startup). Now that initialization is complete the
   // ProcessManager can load deferred background pages.
   manager->MaybeCreateStartupBackgroundHosts();
 }
 
+void ChromeProcessManagerDelegate::OnProfileDestroyed(Profile* profile) {
+  // Close background hosts when the last profile is closed so that they
+  // have time to shutdown various objects on different threads. The
+  // ProfileManager destructor is called too late in the shutdown sequence.
+  // http://crbug.com/15708
+  ProcessManager* manager = ExtensionSystem::Get(profile)->process_manager();
+  if (manager)
+    manager->CloseBackgroundHosts();
+
+  // If this profile owns an incognito profile then close the incognito

[James Cook, 2014/07/24 18:27:54]

This mimics the behavior of the existing code (specifically the part where an
incognito process manager was listening for PROFILE_DESTROYED for the original
non-incognito context.)

It's unclear to me why it's needed. I guess it's because a non-incognito profile
could be destroyed *before* the incognito profile that it owns? So we need to
shut down split-mode extensions before the incognito profile closes?

[Yoyo Zhou, 2014/07/24 20:25:01]

From the CL that added this, I wrote

(which happens in a few tests)

so I think it only happens in test code. That can go into the comment here.

[James Cook, 2014/07/24 21:02:35]

Done.

+  // background hosts as well. http://crbug.com/138843
+  if (!profile->IsOffTheRecord() && profile->HasOffTheRecordProfile()) {
+    ProcessManager* incognito_manager =
+        ExtensionSystem::Get(profile->GetOffTheRecordProfile())
+            ->process_manager();
+    if (incognito_manager)
+      incognito_manager->CloseBackgroundHosts();
+  }
+}
+
 }  // namespace extensions