Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Issue 415853002: Switch to using SSL_get0_certificate_types for client auth. (Closed)

Created:
6 years, 5 months ago by davidben
Modified:
6 years, 5 months ago
Reviewers:
agl
CC:
chromium-reviews, cbentzel+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Switch to using SSL_get0_certificate_types for client auth. Upstream added SSL_get0_certificate_types while we added SSL_get_client_certificate_types in parallel. Switch to upstream's API. BUG=388000 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285498

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M net/socket/ssl_client_socket_openssl.cc View 1 chunk +2 lines, -3 lines 1 comment Download

Messages

Total messages: 10 (0 generated)
davidben
https://codereview.chromium.org/415853002/diff/1/net/socket/ssl_client_socket_openssl.cc File net/socket/ssl_client_socket_openssl.cc (right): https://codereview.chromium.org/415853002/diff/1/net/socket/ssl_client_socket_openssl.cc#newcode1343 net/socket/ssl_client_socket_openssl.cc:1343: SSL_get0_certificate_types(ssl, &client_cert_types); Even though this is upstream's API, it ...
6 years, 5 months ago (2014-07-23 23:27:56 UTC) #1
agl
lgtm
6 years, 5 months ago (2014-07-24 18:26:26 UTC) #2
davidben
The CQ bit was checked by davidben@chromium.org
6 years, 5 months ago (2014-07-24 20:50:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/415853002/1
6 years, 5 months ago (2014-07-24 20:53:29 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel_swarming on tryserver.chromium ...
6 years, 5 months ago (2014-07-24 22:06:51 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-24 22:37:46 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_swarming/builds/2134)
6 years, 5 months ago (2014-07-24 22:37:47 UTC) #7
davidben
The CQ bit was checked by davidben@chromium.org
6 years, 5 months ago (2014-07-25 05:15:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/415853002/1
6 years, 5 months ago (2014-07-25 05:17:08 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 06:03:15 UTC) #10
Message was sent while issue was closed.
Change committed as 285498

Powered by Google App Engine
This is Rietveld 408576698