Switch to using SSL_get0_certificate_types for client auth.

net/socket/ssl_client_socket_openssl.cc

Index: net/socket/ssl_client_socket_openssl.cc
diff --git a/net/socket/ssl_client_socket_openssl.cc b/net/socket/ssl_client_socket_openssl.cc
index 1c00180be94ca7866754dd231994f163c916fc20..ba3c5dff13936bd007399dcdf5bc9d69301e01ae 100644
--- a/net/socket/ssl_client_socket_openssl.cc
+++ b/net/socket/ssl_client_socket_openssl.cc
@@ -1339,9 +1339,8 @@ int SSLClientSocketOpenSSL::ClientCertRequestCallback(SSL* ssl,
     }
 
     const unsigned char* client_cert_types;
-    size_t num_client_cert_types;
-    SSL_get_client_certificate_types(ssl, &client_cert_types,
-                                     &num_client_cert_types);
+    size_t num_client_cert_types =
+        SSL_get0_certificate_types(ssl, &client_cert_types);

[davidben, 2014/07/23 23:27:55]

Even though this is upstream's API, it does have the downside of going through
SSL_ctrl and thus not having any type-checking. ssl2_ctrl is gone now and
dtls1_ctrl is a tiny tiny wrapper over ssl3_ctrl. Perhaps we should start
ripping all the SSL_ctrl switch-case + macro pairs into individual functions?
Would have to be careful about any consumers that call the SSL_ctrl directly,
and any consumers which #ifdef on the macro. But apart from that....

     for (size_t i = 0; i < num_client_cert_types; i++) {
       cert_key_types_.push_back(
           static_cast<SSLClientCertType>(client_cert_types[i]));