CQ: assert instead of re-running verifiers

commit-queue/pending_manager.py

Index: commit-queue/pending_manager.py
===================================================================
--- commit-queue/pending_manager.py	(revision 230860)
+++ commit-queue/pending_manager.py	(working copy)
@@ -357,10 +357,7 @@
     Returns True if all Verifiers were run.
     """
     for verifier in verifiers:
-      if verifier.name in pending.verifications:
-        logging.warning(
-            'Re-running verififer %s for issue %s' % (

[Isaac (away), 2013/10/28 18:16:41]

what happens when you restart CQ and add tests?

[Paweł Hajdan Jr., 2013/10/28 22:57:11]

Seems to work. Still, please note you're doing a _code_ review here.

I'm assuming lack of other comments indicates the code is good.

-                verifier.name, pending.issue))
+      assert verifier.name not in pending.verifications
       verifier.verify(pending)
       assert verifier.name in pending.verifications
       if pending.get_state() == base.IGNORED: