CQ: assert instead of re-running verifiers

commit-queue/pending_manager.py

 # coding=utf8
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 """Commit queue manager class.
 
 Security implications:
 
 The following hypothesis are made:
 - Commit queue:
@@ skipping 339 matching lines @@
           {'verification': 'why not',
            'payload': {'message': pending.why_not()}})
 
   @classmethod
   def _pending_run_verifiers(cls, pending, verifiers):
     """Runs verifiers on a pending change.
 
     Returns True if all Verifiers were run.
     """
     for verifier in verifiers:
-      if verifier.name in pending.verifications:
-        logging.warning(
-            'Re-running verififer %s for issue %s' % (

[Isaac (away), 2013/10/28 18:16:41]

what happens when you restart CQ and add tests?

[Paweł Hajdan Jr., 2013/10/28 22:57:11]

Seems to work. Still, please note you're doing a _code_ review here.

I'm assuming lack of other comments indicates the code is good.

-                verifier.name, pending.issue))
+      assert verifier.name not in pending.verifications
       verifier.verify(pending)
       assert verifier.name in pending.verifications
       if pending.get_state() == base.IGNORED:
         assert pending.verifications[verifier.name].get_state() == base.IGNORED
         # Remove all the other verifiers since we need to keep it in the
         # 'datastore' to not retry this issue constantly.
         for key in pending.verifications.keys():
           if key != verifier.name:
             del pending.verifications[key]
         return False
@@ skipping 177 matching lines @@
     """Loads the commit queue state from a JSON file."""
     self.queue = model.load_from_json_file(filename)
 
   def save(self, filename):
     """Save the commit queue state in a simple JSON file."""
     model.save_to_json_file(filename, self.queue)
 
   def close(self):
     """Close all the active pending manager items."""
     self.context.status.close()