Changes access policy for embedded nodes

Changes access policy for embedded nodes

Once Embed() is called on a node the connection that created the node
can no longer see any of the children. If the node had existing
children they are removed.

BUG=396804
TEST=covered by test
R=ben@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285116

[Ben Goodger (Google), 2014-07-23 22:08:35]

lgtm

I find the use of the empty roots_ for the window manager connection to be
confusing. I think it'd be more intuitive if the window manager had a populated
roots_ like everyone else. Whether or not a connection has the ability to see a
subtree seems like policy that's separate from how the individual connections
track the tree structure.

[sky, 2014-07-23 22:10:28]

Agreed. I'll clean up separately.

On Wed, Jul 23, 2014 at 3:08 PM,  <ben@chromium.org> wrote:
> lgtm
>
> I find the use of the empty roots_ for the window manager connection to be
> confusing. I think it'd be more intuitive if the window manager had a
> populated
> roots_ like everyone else. Whether or not a connection has the ability to
> see a
> subtree seems like policy that's separate from how the individual
> connections
> track the tree structure.
>
> https://codereview.chromium.org/415793003/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[sky, 2014-07-23 22:10:32]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2014-07-23 22:13:47]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sky@chromium.org/415793003/20001

[commit-bot: I haz the power, 2014-07-24 02:25:28]

Change committed as 285116