Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(703)

Unified Diff: mojo/services/public/interfaces/view_manager/view_manager.mojom

Issue 415793003: Changes access policy for embedded nodes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: cleanup Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | mojo/services/view_manager/root_node_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/services/public/interfaces/view_manager/view_manager.mojom
diff --git a/mojo/services/public/interfaces/view_manager/view_manager.mojom b/mojo/services/public/interfaces/view_manager/view_manager.mojom
index a5d27391f76974d2515911e9a3c62fc101aae668..e9477f8e586e16dbaf141862d4c83770b4dc71f2 100644
--- a/mojo/services/public/interfaces/view_manager/view_manager.mojom
+++ b/mojo/services/public/interfaces/view_manager/view_manager.mojom
@@ -76,7 +76,7 @@ interface ViewManagerService {
AddNode(uint32 parent, uint32 child) => (bool success);
// Removes a view from its current parent. This fails if the node is not
- // valid, |server_change_id| doesn't match, or the node already has no parent.
+ // valid or the node already has no parent.
//
// Removing a node from a parent may result in OnNodeDeleted() being sent to
// other connections. For example, connection A has nodes 1 and 2, with 2 a
@@ -134,11 +134,14 @@ interface ViewManagerService {
// current connection. The current connection is told this by way of
// OnNodeDeleted().
//
+ // When a connection embeds an app the connection no longer has priviledges
+ // to access or see any of the children of the node. If the node had existing
+ // children the children are removed. The one exception is the root
+ // connection.
+ //
// If |node_id| is 0, the View Manager delegates determination of what node to
// embed |url| at to the app embedded at the service root node (i.e. the
// window manager).
- //
- // This advances the server change id.
Embed(string url, uint32 node_id) => (bool success);
// TODO(sky): move these to a separate interface when FIFO works.
@@ -168,7 +171,7 @@ interface ViewManagerClient {
// Invoked when a change is done to the hierarchy. A value of 0 is used to
// identify a null node. For example, if the old_parent is NULL, 0 is
- // supplied. See description above ViewManager for details on the change ids.
+ // supplied.
// |nodes| contains any nodes that are that the client has not been told
// about. This is not sent for hierarchy changes of nodes not known to this
// client or not attached to the tree.
« no previous file with comments | « no previous file | mojo/services/view_manager/root_node_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698