Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 415773010: Revert "Tests that the GC doesn't mistake non-pointer constant pool entries as pointers." (Closed)

Created:
6 years, 5 months ago by Michael Achenbach
Modified:
6 years, 5 months ago
Reviewers:
rmcilroy
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Revert "Tests that the GC doesn't mistake non-pointer constant pool entries as pointers." This reverts commit r22608 for breaking win and arm64, ConstantPoolExtended and ConstantPoolSmall. BUG= TBR=rmcilroy@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22609

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -39 lines) Patch
M src/objects-inl.h View 2 chunks +0 lines, -2 lines 0 comments Download
M test/cctest/test-constantpool.cc View 1 chunk +0 lines, -37 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Michael Achenbach
FYI
6 years, 5 months ago (2014-07-24 18:58:57 UTC) #1
Michael Achenbach
6 years, 5 months ago (2014-07-24 18:59:26 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r22609 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698