Issue 415743003: Add tools/imagediff to GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 415743003: Add tools/imagediff to GN build. (Closed)

Created:
6 years, 5 months ago by brettw

Modified:
6 years, 5 months ago

Reviewers:
scottmg

CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add tools/imagediff to GN build. TBR=scottmg Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285042

Patch Set 3 : #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -8 lines)			Patch
M	BUILD.gn	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/shell/BUILD.gn	View	1	1 chunk	+4 lines, -3 lines	0 comments	Download
A +	tools/imagediff/BUILD.gn	View	1 2	1 chunk	+7 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scottmg

https://codereview.chromium.org/415743003/diff/20001/tools/imagediff/BUILD.gn File tools/imagediff/BUILD.gn (right): https://codereview.chromium.org/415743003/diff/20001/tools/imagediff/BUILD.gn#newcode6 tools/imagediff/BUILD.gn:6: output_name = "image_dirr" # Different than dir nam for ...

6 years, 5 months ago (2014-07-23 20:41:30 UTC) #2

brettw

6 years, 5 months ago (2014-07-23 21:15:18 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r285042 (presubmit successful).

Expand Messages | Collapse Messages

Issue 415743003: Add tools/imagediff to GN build. (Closed)

Description

Patch Set 1 #

Patch Set 2 : host #

Patch Set 3 : #

Messages