Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Unified Diff: content/shell/BUILD.gn

Issue 415743003: Add tools/imagediff to GN build. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « BUILD.gn ('k') | tools/imagediff/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/BUILD.gn
diff --git a/content/shell/BUILD.gn b/content/shell/BUILD.gn
index f6e7f4f3f16dc169f84ebdbc2e0d17a148a480d2..cc60ec72ee8a40ccf8abbea61cc6bc9b6d31f968 100644
--- a/content/shell/BUILD.gn
+++ b/content/shell/BUILD.gn
@@ -453,9 +453,10 @@ executable("content_shell") {
}
if (!is_android || !is_android_webview_build) {
- deps += [
- # NOTE: rely on host build of this target.
- #'../tools/imagediff/image_diff.gyp:image_diff', TODO(GYP)
+ # Some tests rely on this tool. It might be nicer if these tests relied on
+ # image diff rather than having content shell depend on it.
+ datadeps = [
+ "//tools/imagediff($host_toolchain)",
]
}
}
« no previous file with comments | « BUILD.gn ('k') | tools/imagediff/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698