Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 415403002: Clean up code a bit in MockPeerConnectionImpl. This addresses an issue in non-clang builds on ubunt… (Closed)

Created:
6 years, 5 months ago by tommi (sloooow) - chröme
Modified:
6 years, 5 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Clean up code a bit in MockPeerConnectionImpl. This addresses an issue in non-clang builds on ubuntu 12.04 using gcc 4.6.4 which has been in there for a while now: The error is as follows: ../../content/renderer/media/mock_peer_connection_impl.cc: In member function 'virtual bool content::MockPeerConnectionImpl::GetStats(webrtc::StatsObserver*, webrtc::MediaStreamTrackInterface*, webrtc::PeerConnectionInterface::StatsOutputLevel)': ../../content/renderer/media/mock_peer_connection_impl.cc:280:3: error: in C++98 'value' must be initialized by constructor, not by '{...}' ../../content/renderer/media/mock_peer_connection_impl.cc:293:5: error: in C++98 'value2' must be initialized by constructor, not by '{...}' R=xians@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285547

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -17 lines) Patch
M content/renderer/media/mock_peer_connection_impl.cc View 1 chunk +19 lines, -17 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tommi (sloooow) - chröme
6 years, 5 months ago (2014-07-24 23:06:13 UTC) #1
tommi (sloooow) - chröme
Rebase
6 years, 5 months ago (2014-07-24 23:12:36 UTC) #2
no longer working on chromium
lgtm I assume you would like to commit it now, so I pressed the commit ...
6 years, 5 months ago (2014-07-25 08:35:00 UTC) #3
no longer working on chromium
The CQ bit was checked by xians@chromium.org
6 years, 5 months ago (2014-07-25 08:35:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommi@chromium.org/415403002/20001
6 years, 5 months ago (2014-07-25 08:36:17 UTC) #5
tommi (sloooow) - chröme
6 years, 5 months ago (2014-07-25 09:58:54 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r285547 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698