Clean up code a bit in MockPeerConnectionImpl. This addresses an issue in non-clang builds on ubunt…

content/renderer/media/mock_peer_connection_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/media/mock_peer_connection_impl.h"
 
 #include <vector>
 
 #include "base/logging.h"
 #include "content/renderer/media/webrtc/mock_peer_connection_dependency_factory.h"
@@ skipping 251 matching lines @@
 }
 
 bool MockPeerConnectionImpl::GetStats(
     webrtc::StatsObserver* observer,
     webrtc::MediaStreamTrackInterface* track,
     StatsOutputLevel level) {
   if (!getstats_result_)
     return false;
 
   DCHECK_EQ(kStatsOutputLevelStandard, level);
-  std::vector<webrtc::StatsReport> reports(track ? 1 : 2);
-  webrtc::StatsReport& report = reports[0];
-  report.id = "1234";
-  report.type = "ssrc";
-  report.timestamp = 42;
-  webrtc::StatsReport::Value value = {
-    webrtc::StatsReport::kStatsValueNameFingerprint,
-    "trackvalue"
-  };
-  report.values.push_back(value);
+  webrtc::StatsReport report1, report2;
+  report1.id = "1234";
+  report1.type = "ssrc";
+  report1.timestamp = 42;
+  report1.values.push_back(
+      webrtc::StatsReport::Value(
+          webrtc::StatsReport::kStatsValueNameFingerprint,
+          "trackvalue"));
+
+  std::vector<webrtc::StatsReport> reports;
+  reports.push_back(report1);
+
   // If selector is given, we pass back one report.
   // If selector is not given, we pass back two.
   if (!track) {
-    webrtc::StatsReport& report2 = reports[1];
     report2.id = "nontrack";
     report2.type = "generic";
     report2.timestamp = 44;
-      report2.values.push_back(value);
-      webrtc::StatsReport::Value value2 = {
-        webrtc::StatsReport::kStatsValueNameFingerprintAlgorithm,
-        "somevalue"
-      };
-      report2.values.push_back(value2);
+    report2.values.push_back(
+        webrtc::StatsReport::Value(
+            webrtc::StatsReport::kStatsValueNameFingerprintAlgorithm,
+            "somevalue"));
+    reports.push_back(report2);
   }
+
   // Note that the callback is synchronous, not asynchronous; it will
   // happen before the request call completes.
   observer->OnComplete(reports);
+
   return true;
 }
 
 const webrtc::SessionDescriptionInterface*
 MockPeerConnectionImpl::local_description() const {
   return local_desc_.get();
 }
 
 const webrtc::SessionDescriptionInterface*
 MockPeerConnectionImpl::remote_description() const {
@@ skipping 48 matching lines @@
   sdp_mline_index_ = candidate->sdp_mline_index();
   return candidate->ToString(&ice_sdp_);
 }
 
 void MockPeerConnectionImpl::RegisterUMAObserver(
     webrtc::UMAObserver* observer) {
   NOTIMPLEMENTED();
 }
 
 }  // namespace content