Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 415293002: Current host warning "Read and modify your data .." should say "Read and change your data .." to ma… (Closed)

Created:
6 years, 5 months ago by mhm
Modified:
6 years, 5 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, aboxhall
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Current host warning "Read and modify your data .." should say "Read and change your data .." to maintain consistency with other strings. As part of the overall effort to cleap up extensions/app warnings we need to ensure the consistency of the wording. All write access should say "change", thus this CL fixes this for hosts permission. BUG=386224 R=jww Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285717

Patch Set 1 #

Patch Set 2 : Fix a typo in a test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M chrome/common/extensions/manifest_handlers/automation_unittest.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/common/extensions/permissions/permission_set_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/management/test/basics.js View 1 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/permissions/permissions_data_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M extensions/extensions_strings.grd View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
mhm
jww@ can you please have a look at this for me.
6 years, 5 months ago (2014-07-24 20:49:09 UTC) #1
jww
lgtm
6 years, 5 months ago (2014-07-25 16:25:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mohammed@chromium.org/415293002/1
6 years, 5 months ago (2014-07-25 16:26:29 UTC) #3
mhm
Fixed a typo in one of the tests.
6 years, 5 months ago (2014-07-25 18:14:08 UTC) #4
mhm
The CQ bit was checked by mohammed@chromium.org
6 years, 5 months ago (2014-07-25 18:14:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mohammed@chromium.org/415293002/20001
6 years, 5 months ago (2014-07-25 18:15:14 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-25 21:57:53 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-25 22:01:46 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/82520)
6 years, 5 months ago (2014-07-25 22:01:47 UTC) #9
mhm
kalman@ can you please owner review this for me.
6 years, 5 months ago (2014-07-25 22:33:38 UTC) #10
not at google - send to devlin
+aboxhall FYI. see who wins in the CQ race.
6 years, 5 months ago (2014-07-25 22:38:05 UTC) #11
not at google - send to devlin
(lgtm)
6 years, 5 months ago (2014-07-25 22:38:10 UTC) #12
mhm
The CQ bit was checked by mohammed@chromium.org
6 years, 5 months ago (2014-07-25 22:49:02 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mohammed@chromium.org/415293002/20001
6 years, 5 months ago (2014-07-25 22:51:22 UTC) #14
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 23:02:52 UTC) #15
Message was sent while issue was closed. 
Change committed as 285717

Powered by Google App Engine
This is Rietveld 408576698