Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1235)

Side by Side Diff: extensions/common/permissions/permissions_data_unittest.cc

Issue 415293002: Current host warning "Read and modify your data .." should say "Read and change your data .." to ma… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix a typo in a test Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <vector> 5 #include <vector>
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/memory/ref_counted.h" 8 #include "base/memory/ref_counted.h"
9 #include "base/strings/string16.h" 9 #include "base/strings/string16.h"
10 #include "base/strings/utf_string_conversions.h" 10 #include "base/strings/utf_string_conversions.h"
(...skipping 264 matching lines...) Expand 10 before | Expand all | Expand 10 after
275 275
276 } 276 }
277 277
278 TEST(ExtensionPermissionsTest, GetPermissionMessages_ManyAPIPermissions) { 278 TEST(ExtensionPermissionsTest, GetPermissionMessages_ManyAPIPermissions) {
279 scoped_refptr<Extension> extension; 279 scoped_refptr<Extension> extension;
280 extension = LoadManifest("permissions", "many-apis.json"); 280 extension = LoadManifest("permissions", "many-apis.json");
281 std::vector<base::string16> warnings = 281 std::vector<base::string16> warnings =
282 extension->permissions_data()->GetPermissionMessageStrings(); 282 extension->permissions_data()->GetPermissionMessageStrings();
283 // Warning for "tabs" is suppressed by "history" permission. 283 // Warning for "tabs" is suppressed by "history" permission.
284 ASSERT_EQ(5u, warnings.size()); 284 ASSERT_EQ(5u, warnings.size());
285 EXPECT_EQ("Read and modify your data on api.flickr.com", 285 EXPECT_EQ("Read and change your data on api.flickr.com",
286 UTF16ToUTF8(warnings[0])); 286 UTF16ToUTF8(warnings[0]));
287 EXPECT_EQ("Read and change your bookmarks", UTF16ToUTF8(warnings[1])); 287 EXPECT_EQ("Read and change your bookmarks", UTF16ToUTF8(warnings[1]));
288 EXPECT_EQ("Detect your physical location", UTF16ToUTF8(warnings[2])); 288 EXPECT_EQ("Detect your physical location", UTF16ToUTF8(warnings[2]));
289 EXPECT_EQ("Read and change your browsing history", UTF16ToUTF8(warnings[3])); 289 EXPECT_EQ("Read and change your browsing history", UTF16ToUTF8(warnings[3]));
290 EXPECT_EQ("Manage your apps, extensions, and themes", 290 EXPECT_EQ("Manage your apps, extensions, and themes",
291 UTF16ToUTF8(warnings[4])); 291 UTF16ToUTF8(warnings[4]));
292 } 292 }
293 293
294 TEST(ExtensionPermissionsTest, GetPermissionMessages_ManyHostsPermissions) { 294 TEST(ExtensionPermissionsTest, GetPermissionMessages_ManyHostsPermissions) {
295 scoped_refptr<Extension> extension; 295 scoped_refptr<Extension> extension;
296 extension = LoadManifest("permissions", "more-than-3-hosts.json"); 296 extension = LoadManifest("permissions", "more-than-3-hosts.json");
297 std::vector<base::string16> warnings = 297 std::vector<base::string16> warnings =
298 extension->permissions_data()->GetPermissionMessageStrings(); 298 extension->permissions_data()->GetPermissionMessageStrings();
299 std::vector<base::string16> warnings_details = 299 std::vector<base::string16> warnings_details =
300 extension->permissions_data()->GetPermissionMessageDetailsStrings(); 300 extension->permissions_data()->GetPermissionMessageDetailsStrings();
301 ASSERT_EQ(1u, warnings.size()); 301 ASSERT_EQ(1u, warnings.size());
302 ASSERT_EQ(1u, warnings_details.size()); 302 ASSERT_EQ(1u, warnings_details.size());
303 EXPECT_EQ("Read and modify your data on a number of websites", 303 EXPECT_EQ("Read and change your data on a number of websites",
304 UTF16ToUTF8(warnings[0])); 304 UTF16ToUTF8(warnings[0]));
305 EXPECT_EQ("- www.a.com\n- www.b.com\n- www.c.com\n- www.d.com\n- www.e.com", 305 EXPECT_EQ("- www.a.com\n- www.b.com\n- www.c.com\n- www.d.com\n- www.e.com",
306 UTF16ToUTF8(warnings_details[0])); 306 UTF16ToUTF8(warnings_details[0]));
307 } 307 }
308 308
309 TEST(ExtensionPermissionsTest, GetPermissionMessages_LocationApiPermission) { 309 TEST(ExtensionPermissionsTest, GetPermissionMessages_LocationApiPermission) {
310 scoped_refptr<Extension> extension; 310 scoped_refptr<Extension> extension;
311 extension = LoadManifest("permissions", 311 extension = LoadManifest("permissions",
312 "location-api.json", 312 "location-api.json",
313 Manifest::COMPONENT, 313 Manifest::COMPONENT,
314 Extension::NO_FLAGS); 314 Extension::NO_FLAGS);
315 std::vector<base::string16> warnings = 315 std::vector<base::string16> warnings =
316 extension->permissions_data()->GetPermissionMessageStrings(); 316 extension->permissions_data()->GetPermissionMessageStrings();
317 ASSERT_EQ(1u, warnings.size()); 317 ASSERT_EQ(1u, warnings.size());
318 EXPECT_EQ("Detect your physical location", UTF16ToUTF8(warnings[0])); 318 EXPECT_EQ("Detect your physical location", UTF16ToUTF8(warnings[0]));
319 } 319 }
320 320
321 TEST(ExtensionPermissionsTest, GetPermissionMessages_ManyHosts) { 321 TEST(ExtensionPermissionsTest, GetPermissionMessages_ManyHosts) {
322 scoped_refptr<Extension> extension; 322 scoped_refptr<Extension> extension;
323 extension = LoadManifest("permissions", "many-hosts.json"); 323 extension = LoadManifest("permissions", "many-hosts.json");
324 std::vector<base::string16> warnings = 324 std::vector<base::string16> warnings =
325 extension->permissions_data()->GetPermissionMessageStrings(); 325 extension->permissions_data()->GetPermissionMessageStrings();
326 ASSERT_EQ(1u, warnings.size()); 326 ASSERT_EQ(1u, warnings.size());
327 EXPECT_EQ( 327 EXPECT_EQ(
328 "Read and modify your data on encrypted.google.com and www.google.com", 328 "Read and change your data on encrypted.google.com and www.google.com",
329 UTF16ToUTF8(warnings[0])); 329 UTF16ToUTF8(warnings[0]));
330 } 330 }
331 331
332 TEST(ExtensionPermissionsTest, GetPermissionMessages_Plugins) { 332 TEST(ExtensionPermissionsTest, GetPermissionMessages_Plugins) {
333 scoped_refptr<Extension> extension; 333 scoped_refptr<Extension> extension;
334 extension = LoadManifest("permissions", "plugins.json"); 334 extension = LoadManifest("permissions", "plugins.json");
335 std::vector<base::string16> warnings = 335 std::vector<base::string16> warnings =
336 extension->permissions_data()->GetPermissionMessageStrings(); 336 extension->permissions_data()->GetPermissionMessageStrings();
337 // We don't parse the plugins key on Chrome OS, so it should not ask for any 337 // We don't parse the plugins key on Chrome OS, so it should not ask for any
338 // permissions. 338 // permissions.
(...skipping 407 matching lines...) Expand 10 before | Expand all | Expand 10 after
746 746
747 permissions_data->ClearTabSpecificPermissions(1); 747 permissions_data->ClearTabSpecificPermissions(1);
748 EXPECT_FALSE(permissions_data->GetTabSpecificPermissionsForTesting(1)); 748 EXPECT_FALSE(permissions_data->GetTabSpecificPermissionsForTesting(1));
749 749
750 EXPECT_TRUE(ScriptAllowedExclusivelyOnTab(extension.get(), no_urls, 0)); 750 EXPECT_TRUE(ScriptAllowedExclusivelyOnTab(extension.get(), no_urls, 0));
751 EXPECT_TRUE(ScriptAllowedExclusivelyOnTab(extension.get(), no_urls, 1)); 751 EXPECT_TRUE(ScriptAllowedExclusivelyOnTab(extension.get(), no_urls, 1));
752 EXPECT_TRUE(ScriptAllowedExclusivelyOnTab(extension.get(), no_urls, 2)); 752 EXPECT_TRUE(ScriptAllowedExclusivelyOnTab(extension.get(), no_urls, 2));
753 } 753 }
754 754
755 } // namespace extensions 755 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/test/data/extensions/api_test/management/test/basics.js ('k') | extensions/extensions_strings.grd » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698