Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: ui/gl/gl_image.h

Issue 415283002: ui: Add ScheduleOverlayPlane API to GLImage. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: android build fix Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/command_buffer/service/texture_definition.cc ('k') | ui/gl/gl_image_android_native_buffer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gl/gl_image.h
diff --git a/ui/gl/gl_image.h b/ui/gl/gl_image.h
index 45303fd64602321259973a4090478e645390ca37..4b1e9da3786d869083f19ccc5dd45539a4fbec1d 100644
--- a/ui/gl/gl_image.h
+++ b/ui/gl/gl_image.h
@@ -6,6 +6,9 @@
#define UI_GL_GL_IMAGE_H_
#include "base/memory/ref_counted.h"
+#include "ui/gfx/overlay_transform.h"
+#include "ui/gfx/rect.h"
+#include "ui/gfx/rect_f.h"
#include "ui/gfx/size.h"
#include "ui/gl/gl_export.h"
@@ -41,6 +44,20 @@ class GL_EXPORT GLImage : public base::RefCounted<GLImage> {
// Called after the texture image data has been modified.
virtual void DidModifyTexImage() = 0;
+ // Schedule image as an overlay plane to be shown at swap time.
+ // |z_order| specifies the stacking order of the plane relative to the
+ // main framebuffer located at index 0. For the case where there is no
+ // main framebuffer, overlays may be scheduled at 0, taking its place.
+ // |transform| specifies how the buffer is to be transformed during
+ // composition.
+ // |bounds_rect| specify where it is supposed to be on the screen in pixels.
+ // |crop_rect| specifies the region within the buffer to be placed inside
+ // |bounds_rect|.
+ virtual bool ScheduleOverlayPlane(int z_order,
+ OverlayTransform transform,
+ const Rect& bounds_rect,
+ const RectF& crop_rect) = 0;
piman 2014/07/30 20:11:42 I'm not sure how this API works without extra cont
alexst (slow to review) 2014/07/30 20:21:48 Re: extra context, I just commented on that before
+
// Indicate that image should be released after use.
// (For an Android work-around only).
virtual void SetReleaseAfterUse();
« no previous file with comments | « gpu/command_buffer/service/texture_definition.cc ('k') | ui/gl/gl_image_android_native_buffer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698