components/metrics/proto/omnibox_event.proto - Issue 415053002: Remove AutocompleteMatch::is_starred

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/metrics/proto/omnibox_event.proto

Issue 415053002: Remove AutocompleteMatch::is_starred (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/metrics/proto/omnibox_event.proto

diff --git a/components/metrics/proto/omnibox_event.proto b/components/metrics/proto/omnibox_event.proto

index bd619f002101c99ef5b1a436a23ba55d918368c0..9777fb130bb0d8d031487c629f7fb2986f58937f 100644

--- a/components/metrics/proto/omnibox_event.proto

+++ b/components/metrics/proto/omnibox_event.proto

@@ -228,7 +228,7 @@ message OmniboxEventProto {

optional int32 typed_count = 5;

// Whether this item is starred (bookmarked) or not.

- optional bool is_starred = 4;

+ optional bool is_starred = 4 [deprecated=true];

Ilya Sherman 2014/07/25 20:13:56 Thanks. Please make this changer server-side as w

hashimoto 2014/07/28 06:49:43 OK, I will.

// Whether this item is disabled in the UI (not clickable).

optional bool is_disabled = 6;