Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: components/metrics/proto/omnibox_event.proto

Issue 415053002: Remove AutocompleteMatch::is_starred (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Stores information about an omnibox interaction. 5 // Stores information about an omnibox interaction.
6 6
7 syntax = "proto2"; 7 syntax = "proto2";
8 8
9 option optimize_for = LITE_RUNTIME; 9 option optimize_for = LITE_RUNTIME;
10 10
(...skipping 210 matching lines...) Expand 10 before | Expand all | Expand 10 after
221 // The relevance score for this suggestion. 221 // The relevance score for this suggestion.
222 optional int32 relevance = 3; 222 optional int32 relevance = 3;
223 223
224 // How many times this result was typed in / selected from the omnibox. 224 // How many times this result was typed in / selected from the omnibox.
225 // Only set for some providers and result_types. At the time of 225 // Only set for some providers and result_types. At the time of
226 // writing this comment, it is only set for HistoryURL and 226 // writing this comment, it is only set for HistoryURL and
227 // HistoryQuickProvider matches. 227 // HistoryQuickProvider matches.
228 optional int32 typed_count = 5; 228 optional int32 typed_count = 5;
229 229
230 // Whether this item is starred (bookmarked) or not. 230 // Whether this item is starred (bookmarked) or not.
231 optional bool is_starred = 4; 231 optional bool is_starred = 4 [deprecated=true];
Ilya Sherman 2014/07/25 20:13:56 Thanks. Please make this changer server-side as w
hashimoto 2014/07/28 06:49:43 OK, I will.
232 232
233 // Whether this item is disabled in the UI (not clickable). 233 // Whether this item is disabled in the UI (not clickable).
234 optional bool is_disabled = 6; 234 optional bool is_disabled = 6;
235 } 235 }
236 repeated Suggestion suggestion = 9; 236 repeated Suggestion suggestion = 9;
237 237
238 // A data structure that holds per-provider information, general information 238 // A data structure that holds per-provider information, general information
239 // not associated with a particular result. 239 // not associated with a particular result.
240 // Next tag: 6 240 // Next tag: 6
241 message ProviderInfo { 241 message ProviderInfo {
(...skipping 24 matching lines...) Expand all
266 // The number of times this provider returned a non-zero number of 266 // The number of times this provider returned a non-zero number of
267 // suggestions during this omnibox session. 267 // suggestions during this omnibox session.
268 // Note that each provider may define a session differently for its 268 // Note that each provider may define a session differently for its
269 // purposes. 269 // purposes.
270 optional int32 times_returned_results_in_session = 5; 270 optional int32 times_returned_results_in_session = 5;
271 } 271 }
272 // A list of diagnostic information about each provider. Providers 272 // A list of diagnostic information about each provider. Providers
273 // will appear at most once in this list. 273 // will appear at most once in this list.
274 repeated ProviderInfo provider_info = 12; 274 repeated ProviderInfo provider_info = 12;
275 } 275 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698