Oilpan: Prepare moving InspectorFrontendHost to Oilpan

Source/web/InspectorFrontendClientImpl.cpp

Index: Source/web/InspectorFrontendClientImpl.cpp
diff --git a/Source/web/InspectorFrontendClientImpl.cpp b/Source/web/InspectorFrontendClientImpl.cpp
index dec64f2ae13ef0385262df036f12230f2bab36bd..06d7454de5e4b0ca37562ab9a9e1ef240104eff0 100644
--- a/Source/web/InspectorFrontendClientImpl.cpp
+++ b/Source/web/InspectorFrontendClientImpl.cpp
@@ -54,11 +54,26 @@ InspectorFrontendClientImpl::InspectorFrontendClientImpl(Page* frontendPage, Web
 
 InspectorFrontendClientImpl::~InspectorFrontendClientImpl()
 {
+#if !ENABLE(OILPAN)
     if (m_frontendHost)
         m_frontendHost->disconnectClient();
+#endif

[haraken, 2014/07/25 01:05:02]

Can we simply remove disconnectClient from ~InspectorFrontendClientImpl() in
non-oilpan builds as well, since it should be already done in dispose()?

Also we can clear m_frontendHost in dispose() and add ASSERT(!m_frontendHost) in
~InspectorFrontendClientImpl().

Can we move 'm_client = 0' to dispose() as well?

[keishi, 2014/07/25 01:36:34]

Done.

     m_client = 0;
 }
 
+void InspectorFrontendClientImpl::trace(Visitor* visitor)
+{
+    visitor->trace(m_frontendPage);
+    visitor->trace(m_frontendHost);
+    InspectorFrontendClient::trace(visitor);
+}
+
+void InspectorFrontendClientImpl::dispose()
+{
+    if (m_frontendHost)
+        m_frontendHost->disconnectClient();
+}
+
 void InspectorFrontendClientImpl::windowObjectCleared()
 {
     v8::Isolate* isolate = v8::Isolate::GetCurrent();