Oilpan: Prepare moving InspectorFrontendHost to Oilpan

Source/web/InspectorFrontendClientImpl.cpp

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 36 matching lines @@
 namespace blink {
 
 InspectorFrontendClientImpl::InspectorFrontendClientImpl(Page* frontendPage, WebDevToolsFrontendClient* client, WebDevToolsFrontendImpl* frontend)
     : m_frontendPage(frontendPage)
     , m_client(client)
 {
 }
 
 InspectorFrontendClientImpl::~InspectorFrontendClientImpl()
 {
+#if !ENABLE(OILPAN)
     if (m_frontendHost)
         m_frontendHost->disconnectClient();
+#endif

[haraken, 2014/07/25 01:05:02]

Can we simply remove disconnectClient from ~InspectorFrontendClientImpl() in
non-oilpan builds as well, since it should be already done in dispose()?

Also we can clear m_frontendHost in dispose() and add ASSERT(!m_frontendHost) in
~InspectorFrontendClientImpl().

Can we move 'm_client = 0' to dispose() as well?

[keishi, 2014/07/25 01:36:34]

Done.

     m_client = 0;
 }
 
+void InspectorFrontendClientImpl::trace(Visitor* visitor)
+{
+    visitor->trace(m_frontendPage);
+    visitor->trace(m_frontendHost);
+    InspectorFrontendClient::trace(visitor);
+}
+
+void InspectorFrontendClientImpl::dispose()
+{
+    if (m_frontendHost)
+        m_frontendHost->disconnectClient();
+}
+
 void InspectorFrontendClientImpl::windowObjectCleared()
 {
     v8::Isolate* isolate = v8::Isolate::GetCurrent();
     ASSERT(m_frontendPage->mainFrame());
     ScriptState* scriptState = ScriptState::forMainWorld(m_frontendPage->deprecatedLocalMainFrame());
     ScriptState::Scope scope(scriptState);
 
     if (m_frontendHost)
         m_frontendHost->disconnectClient();
     m_frontendHost = InspectorFrontendHost::create(this, m_frontendPage);
@@ skipping 85 matching lines @@
 {
     m_client->sendMessageToEmbedder(message);
 }
 
 bool InspectorFrontendClientImpl::isUnderTest()
 {
     return m_client->isUnderTest();
 }
 
 } // namespace blink