Oilpan: Prepare moving InspectorFrontendHost to Oilpan

Oilpan: Prepare moving InspectorFrontendHost to Oilpan

BUG=340522
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179021

[haraken, 2014-07-24 07:16:29]

LGTM

https://codereview.chromium.org/415043003/diff/1/Source/web/InspectorFrontend...
File Source/web/InspectorFrontendClientImpl.h (right):

https://codereview.chromium.org/415043003/diff/1/Source/web/InspectorFrontend...
Source/web/InspectorFrontendClientImpl.h:64: blink::Page* m_frontendPage;

Can we make this a RawPtrWillBeMember?

[yurys, 2014-07-24 08:09:17]

lgtm

[keishi, 2014-07-25 00:59:33]

https://codereview.chromium.org/415043003/diff/1/Source/web/InspectorFrontend...
File Source/web/InspectorFrontendClientImpl.h (right):

https://codereview.chromium.org/415043003/diff/1/Source/web/InspectorFrontend...
Source/web/InspectorFrontendClientImpl.h:64: blink::Page* m_frontendPage;
On 2014/07/24 07:16:28, haraken wrote:
> 
> Can we make this a RawPtrWillBeMember?

I moved InspectorFrontendClient to the heap so it can be a Member.

[haraken, 2014-07-25 01:05:02]

https://codereview.chromium.org/415043003/diff/20001/Source/web/InspectorFron...
File Source/web/InspectorFrontendClientImpl.cpp (right):

https://codereview.chromium.org/415043003/diff/20001/Source/web/InspectorFron...
Source/web/InspectorFrontendClientImpl.cpp:60: #endif

Can we simply remove disconnectClient from ~InspectorFrontendClientImpl() in
non-oilpan builds as well, since it should be already done in dispose()?

Also we can clear m_frontendHost in dispose() and add ASSERT(!m_frontendHost) in
~InspectorFrontendClientImpl().

Can we move 'm_client = 0' to dispose() as well?

[keishi, 2014-07-25 01:36:35]

https://codereview.chromium.org/415043003/diff/20001/Source/web/InspectorFron...
File Source/web/InspectorFrontendClientImpl.cpp (right):

https://codereview.chromium.org/415043003/diff/20001/Source/web/InspectorFron...
Source/web/InspectorFrontendClientImpl.cpp:60: #endif
On 2014/07/25 01:05:02, haraken wrote:
> 
> Can we simply remove disconnectClient from ~InspectorFrontendClientImpl() in
> non-oilpan builds as well, since it should be already done in dispose()?
> 
> Also we can clear m_frontendHost in dispose() and add ASSERT(!m_frontendHost)
in
> ~InspectorFrontendClientImpl().
> 
> Can we move 'm_client = 0' to dispose() as well?

Done.

[haraken, 2014-07-25 01:40:26]

LGTM

[keishi, 2014-07-28 08:56:29]

The CQ bit was checked by keishi@chromium.org

[commit-bot: I haz the power, 2014-07-28 08:56:47]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/keishi@chromium.org/415043003/40001

[commit-bot: I haz the power, 2014-07-28 09:59:05]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/1...)

[tkent, 2014-07-28 10:01:39]

lgtm

[commit-bot: I haz the power, 2014-07-28 10:01:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-28 10:01:42]

Try jobs failed on following builders:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/1...)

[tkent, 2014-07-28 10:02:05]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2014-07-28 10:02:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/keishi@chromium.org/415043003/40001

[keishi, 2014-07-28 10:05:13]

The CQ bit was checked by keishi@chromium.org

[commit-bot: I haz the power, 2014-07-28 10:06:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/keishi@chromium.org/415043003/60001

[commit-bot: I haz the power, 2014-07-28 11:06:20]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/19201)

[commit-bot: I haz the power, 2014-07-28 11:34:45]

Change committed as 179021