Issue 414973002: Add missing base files to GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 414973002: Add missing base files to GN build. (Closed)

Created:
6 years, 5 months ago by brettw

Modified:
6 years, 5 months ago

Reviewers:
viettrungluu

CC:
chromium-reviews, vsevik, erikwright+watch_chromium.org, jam, yurys, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add missing base files to GN build. Fix the devtools resources target to use the grit template. Fix the grit template to use the correct output directory for the expected files if one is specified R=viettrungluu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285334

Patch Set 1 #

Patch Set 2 : Fix grit outputs #

Patch Set 3 : #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -32 lines)			Patch
M	base/BUILD.gn	View		5 chunks	+12 lines, -0 lines	0 comments	Download
M	build/config/android/rules.gni	View	1 2	1 chunk	+3 lines, -4 lines	0 comments	Download
M	build/secondary/tools/grit/grit_rule.gni	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/browser/devtools/BUILD.gn	View		1 chunk	+10 lines, -26 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

brettw

6 years, 5 months ago (2014-07-24 18:24:35 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r285334 (presubmit successful).

Expand Messages | Collapse Messages