Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: build/config/android/rules.gni

Issue 414973002: Add missing base files to GN build. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/BUILD.gn ('k') | build/secondary/tools/grit/grit_rule.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/android/rules.gni
diff --git a/build/config/android/rules.gni b/build/config/android/rules.gni
index f18c86a4bc6e85289ba53c96bcad012ea5f0bdd6..c6b7cc1a87f2fbeb09b30a2637c97fb57832e71d 100644
--- a/build/config/android/rules.gni
+++ b/build/config/android/rules.gni
@@ -362,17 +362,16 @@ template("java_strings_grd") {
"-E", "ANDROID_JAVA_TAGGED_ONLY=false",
]
output_dir = grit_output_dir
+ print("output_dir", output_dir)
resource_ids = ""
source = invoker.grd_file
- # The grit rule expects files relative to target_gen_dir, but this rule
- # appends a suffix to that. This rebase will prepend extra_output_path to
- # each filename.
- outputs = rebase_path(invoker.outputs, ".", extra_output_path)
+ outputs = invoker.outputs
}
# This needs to get outputs from grit's internal target, not the final
# source_set.
generate_strings_outputs = get_target_outputs(":${grit_target_name}_grit")
+ print("gen outputs", generate_strings_outputs)
zip("${target_name}__zip") {
base_dir = grit_output_dir
« no previous file with comments | « base/BUILD.gn ('k') | build/secondary/tools/grit/grit_rule.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698