Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: ppapi/shared_impl/media_stream_audio_track_shared_unittest.cc

Issue 414643003: Support configuring the audio buffer duration in the Pepper MediaStream API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add clarifying comment about buffer size. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/shared_impl/media_stream_audio_track_shared_unittest.cc
diff --git a/ppapi/shared_impl/media_stream_audio_track_shared_unittest.cc b/ppapi/shared_impl/media_stream_audio_track_shared_unittest.cc
index 00cd90576bb4a63a26166a45012e5a39e7cb8b2c..78c10480c4382515a7f4f07b4f10672d69436648 100644
--- a/ppapi/shared_impl/media_stream_audio_track_shared_unittest.cc
+++ b/ppapi/shared_impl/media_stream_audio_track_shared_unittest.cc
@@ -28,6 +28,28 @@ TEST(MediaStreamAudioTrackShared, Verify) {
attributes.buffers = -1;
EXPECT_FALSE(MediaStreamAudioTrackShared::VerifyAttributes(attributes));
}
+
+ // Verify duration
+ {
+ MediaStreamAudioTrackShared::Attributes attributes;
+ attributes.duration = 0;
+ EXPECT_TRUE(MediaStreamAudioTrackShared::VerifyAttributes(attributes));
+
+ attributes.duration = 10;
+ EXPECT_TRUE(MediaStreamAudioTrackShared::VerifyAttributes(attributes));
+
+ attributes.duration = 10000;
+ EXPECT_TRUE(MediaStreamAudioTrackShared::VerifyAttributes(attributes));
+
+ attributes.duration = 123;
+ EXPECT_TRUE(MediaStreamAudioTrackShared::VerifyAttributes(attributes));
+
+ attributes.duration = 9;
+ EXPECT_FALSE(MediaStreamAudioTrackShared::VerifyAttributes(attributes));
+
+ attributes.duration = -1;
+ EXPECT_FALSE(MediaStreamAudioTrackShared::VerifyAttributes(attributes));
+ }
}
} // namespace ppapi

Powered by Google App Engine
This is Rietveld 408576698