ppapi/shared_impl/media_stream_audio_track_shared.cc - Issue 414643003: Support configuring the audio buffer duration in the Pepper MediaStream API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/shared_impl/media_stream_audio_track_shared.cc

Issue 414643003: Support configuring the audio buffer duration in the Pepper MediaStream API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add clarifying comment about buffer size. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/pepper/pepper_media_stream_audio_track_host.cc ('K') | « ppapi/shared_impl/media_stream_audio_track_shared.h ('k') | ppapi/shared_impl/media_stream_audio_track_shared_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ppapi/shared_impl/media_stream_audio_track_shared.cc

diff --git a/ppapi/shared_impl/media_stream_audio_track_shared.cc b/ppapi/shared_impl/media_stream_audio_track_shared.cc

index ac649547d8c8bb32ac6248ef6de66033ef879641..4a9fdb7dcc05fe3ae9cc7f376bf4fa9f27665df6 100644

--- a/ppapi/shared_impl/media_stream_audio_track_shared.cc

+++ b/ppapi/shared_impl/media_stream_audio_track_shared.cc

@@ -11,6 +11,9 @@ bool MediaStreamAudioTrackShared::VerifyAttributes(

const Attributes& attributes) {

if (attributes.buffers < 0)

return false;

+ if (!(attributes.duration == 0 ||

+ (attributes.duration >= 10 && attributes.duration <= 10000)))

+ return false;

return true;

}