Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 414573002: Move vertex buffer setup out of drawPackedGlyph(). (Closed)

Created:
6 years, 5 months ago by jvanverth1
Modified:
6 years, 5 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Move vertex buffer setup out of drawPackedGlyph(). This gets a very welcome ~10% speedup on my Mac. Committed: https://skia.googlesource.com/skia/+/1d38619389cc1100bd516b9acbf17b7bd42d33ce Committed: https://skia.googlesource.com/skia/+/f17bc6cf7ae4b6483ff3a5f52b0672e4243011e3

Patch Set 1 #

Patch Set 2 : Fix rendering issue; minor clean ups #

Patch Set 3 : Make sure we release vertex pool; get rid of unnecessary texture ptr. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -136 lines) Patch
M src/gpu/GrBitmapTextContext.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/GrBitmapTextContext.cpp View 1 2 10 chunks +57 lines, -68 lines 0 comments Download
M src/gpu/GrDistanceFieldTextContext.h View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M src/gpu/GrDistanceFieldTextContext.cpp View 1 2 12 chunks +53 lines, -63 lines 0 comments Download
M src/gpu/GrTextStrike.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
jvanverth1
(I'll fix the overlong lines in GrDistanceFieldTextContext when I add vertex colors.)
6 years, 5 months ago (2014-07-24 18:07:37 UTC) #1
bsalomon
lgtm. Are there any remaining callers for the geometry hints stuff? If not, let's whack ...
6 years, 5 months ago (2014-07-24 18:13:36 UTC) #2
jvanverth1
On 2014/07/24 18:13:36, bsalomon wrote: > lgtm. Are there any remaining callers for the geometry ...
6 years, 5 months ago (2014-07-24 18:40:48 UTC) #3
jvanverth1
The CQ bit was checked by jvanverth@google.com
6 years, 5 months ago (2014-07-25 18:18:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/414573002/20001
6 years, 5 months ago (2014-07-25 18:20:02 UTC) #5
commit-bot: I haz the power
Change committed as 1d38619389cc1100bd516b9acbf17b7bd42d33ce
6 years, 5 months ago (2014-07-25 18:31:19 UTC) #6
jvanverth1
A revert of this CL has been created in https://codereview.chromium.org/419943002/ by jvanverth@google.com. The reason for ...
6 years, 5 months ago (2014-07-25 18:51:58 UTC) #7
jvanverth1
The CQ bit was checked by jvanverth@google.com
6 years, 5 months ago (2014-07-25 23:34:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/414573002/40001
6 years, 5 months ago (2014-07-25 23:34:51 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 23:46:58 UTC) #10
Message was sent while issue was closed.
Change committed as f17bc6cf7ae4b6483ff3a5f52b0672e4243011e3

Powered by Google App Engine
This is Rietveld 408576698