Handles proxy authentication request in ProxyResolvingClientSocket

jingle/glue/proxy_resolving_client_socket.cc

Index: jingle/glue/proxy_resolving_client_socket.cc
diff --git a/jingle/glue/proxy_resolving_client_socket.cc b/jingle/glue/proxy_resolving_client_socket.cc
index 545a9882549c30f34d2f5df5646e7194386be462..4149ee887ff2218d79b01ff05bf29170a019c39a 100644
--- a/jingle/glue/proxy_resolving_client_socket.cc
+++ b/jingle/glue/proxy_resolving_client_socket.cc
@@ -13,6 +13,7 @@
 #include "net/base/load_flags.h"
 #include "net/base/net_errors.h"
 #include "net/http/http_network_session.h"
+#include "net/http/proxy_client_socket.h"
 #include "net/socket/client_socket_handle.h"
 #include "net/socket/client_socket_pool_manager.h"
 #include "net/url_request/url_request_context.h"
@@ -270,6 +271,9 @@ int ProxyResolvingClientSocket::ReconsiderProxyAfterError(int error) {
       // "address unreachable" error, and will report both of these failures as
       // ERR_ADDRESS_UNREACHABLE.
       return net::ERR_ADDRESS_UNREACHABLE;
+    case net::ERR_PROXY_AUTH_REQUESTED:
+      return static_cast<net::ProxyClientSocket*>(transport_->socket())

[Ryan Sleevi, 2014/08/26 21:41:18]

This strikes me as a dangerous assumption that's not guaranteed - but I don't
have any better suggestions here. It at least matches what HttpSTreamFactoryImpl
assumes. 

Our API is all sorts of weirdness:
https://code.google.com/p/chromium/codesearch#chromium/src/net/http/http_netw...
passes |credentials|

which calls
https://code.google.com/p/chromium/codesearch#chromium/src/net/http/http_stre...
, passing |credentials|

which calls
https://code.google.com/p/chromium/codesearch#chromium/src/net/http/http_stre...

... which just ignores |credentials| entirely, and ends up setting the state
machine to hit

https://code.google.com/p/chromium/codesearch#chromium/src/net/http/http_stre...

Which is how I know it's "safe"



However, none of this is a 'public' guarantee of the //net API, hence the
danger.

[asanka, 2014/08/26 22:34:03]

RestartWithAuth() only makes progress for the case where there's a valid
identity selected and credentials are available. The ERR_PROXY_AUTH_REQUESTED
can also be returned when there are no credentials to use, in which case you are
likely to cycle around forever.

[jiayl, 2014/08/26 22:41:48]

What do you suggest to do?
Does it return error if it does not have identity/credential?

On 2014/08/26 22:34:03, asanka wrote:

+          ->RestartWithAuth(connect_callback_);
     default:
       return error;
   }