Handles proxy authentication request in ProxyResolvingClientSocket

jingle/glue/proxy_resolving_client_socket.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "jingle/glue/proxy_resolving_client_socket.h"
 
 #include "base/basictypes.h"
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/compiler_specific.h"
 #include "base/logging.h"
 #include "net/base/io_buffer.h"
 #include "net/base/load_flags.h"
 #include "net/base/net_errors.h"
 #include "net/http/http_network_session.h"
+#include "net/http/proxy_client_socket.h"
 #include "net/socket/client_socket_handle.h"
 #include "net/socket/client_socket_pool_manager.h"
 #include "net/url_request/url_request_context.h"
 #include "net/url_request/url_request_context_getter.h"
 
 namespace jingle_glue {
 
 ProxyResolvingClientSocket::ProxyResolvingClientSocket(
     net::ClientSocketFactory* socket_factory,
     const scoped_refptr<net::URLRequestContextGetter>& request_context_getter,
@@ skipping 237 matching lines @@
     case net::ERR_SOCKS_CONNECTION_HOST_UNREACHABLE:
       // Remap the SOCKS-specific "host unreachable" error to a more
       // generic error code (this way consumers like the link doctor
       // know to substitute their error page).
       //
       // Note that if the host resolving was done by the SOCSK5 proxy, we can't
       // differentiate between a proxy-side "host not found" versus a proxy-side
       // "address unreachable" error, and will report both of these failures as
       // ERR_ADDRESS_UNREACHABLE.
       return net::ERR_ADDRESS_UNREACHABLE;
+    case net::ERR_PROXY_AUTH_REQUESTED:
+      return static_cast<net::ProxyClientSocket*>(transport_->socket())

[Ryan Sleevi, 2014/08/26 21:41:18]

This strikes me as a dangerous assumption that's not guaranteed - but I don't
have any better suggestions here. It at least matches what HttpSTreamFactoryImpl
assumes. 

Our API is all sorts of weirdness:
https://code.google.com/p/chromium/codesearch#chromium/src/net/http/http_netw...
passes |credentials|

which calls
https://code.google.com/p/chromium/codesearch#chromium/src/net/http/http_stre...
, passing |credentials|

which calls
https://code.google.com/p/chromium/codesearch#chromium/src/net/http/http_stre...

... which just ignores |credentials| entirely, and ends up setting the state
machine to hit

https://code.google.com/p/chromium/codesearch#chromium/src/net/http/http_stre...

Which is how I know it's "safe"



However, none of this is a 'public' guarantee of the //net API, hence the
danger.

[asanka, 2014/08/26 22:34:03]

RestartWithAuth() only makes progress for the case where there's a valid
identity selected and credentials are available. The ERR_PROXY_AUTH_REQUESTED
can also be returned when there are no credentials to use, in which case you are
likely to cycle around forever.

[jiayl, 2014/08/26 22:41:48]

What do you suggest to do?
Does it return error if it does not have identity/credential?

On 2014/08/26 22:34:03, asanka wrote:

+          ->RestartWithAuth(connect_callback_);
     default:
       return error;
   }
 
   if (proxy_info_.is_https() && ssl_config_.send_client_cert) {
     network_session_->ssl_client_auth_cache()->Remove(
         proxy_info_.proxy_server().host_port_pair());
   }
 
   int rv = network_session_->proxy_service()->ReconsiderProxyAfterError(
@@ skipping 116 matching lines @@
   return false;
 }
 
 void ProxyResolvingClientSocket::CloseTransportSocket() {
   if (transport_.get() && transport_->socket())
     transport_->socket()->Disconnect();
   transport_.reset();
 }
 
 }  // namespace jingle_glue