Source/core/rendering/RenderBox.cpp - Issue 414503002: Enable paint invalidation container ASSERT

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderBox.cpp

Issue 414503002: Enable paint invalidation container ASSERT (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Dummy rebaseline for the picky trybots :( Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/RenderBox.cpp

diff --git a/Source/core/rendering/RenderBox.cpp b/Source/core/rendering/RenderBox.cpp

index 830261ff0c84953cdac060807eb7142a42a32ace..5533b96755de441df8d24ff00393e956b6d9bdc4 100644

--- a/Source/core/rendering/RenderBox.cpp

+++ b/Source/core/rendering/RenderBox.cpp

@@ -1550,8 +1550,7 @@ void RenderBox::invalidateTreeIfNeeded(const PaintInvalidationState& paintInvali

bool establishesNewPaintInvalidationContainer = isPaintInvalidationContainer();

const RenderLayerModelObject& newPaintInvalidationContainer = *adjustCompositedContainerForSpecialAncestors(establishesNewPaintInvalidationContainer ? this : &paintInvalidationState.paintInvalidationContainer());

- // FIXME: This assert should be re-enabled when we move paint invalidation to after compositing update. crbug.com/360286

- // ASSERT(&newPaintInvalidationContainer == containerForPaintInvalidation());

+ ASSERT(&newPaintInvalidationContainer == containerForPaintInvalidation());

invalidatePaintIfNeeded(paintInvalidationState, newPaintInvalidationContainer);

« no previous file with comments | « no previous file | Source/core/rendering/RenderLayer.cpp » ('j') | no next file with comments »