Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 414363003: Revert 285437 "Block on LaunchProcess failing on specific bot" (Closed)

Created:
6 years, 5 months ago by viettrungluu
Modified:
6 years, 5 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 285437 "Block on LaunchProcess failing on specific bot" scottmg told me to do this. > Block on LaunchProcess failing on specific bot > > Block in a loop if we get a specific failure on a particular bot. > See environment variables at http://build.chromium.org/p/chromium.win/builders/Win8%20Aura/builds/20713/steps/views_unittests/logs/stdio for reference. > > Timeout raise attempted at https://codereview.chromium.org/410353004/ so > that there will be time to attach a debugger. > > R=brettw@chromium.org > BUG=340422 > > Review URL: https://codereview.chromium.org/411223002 TBR=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285734

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M trunk/src/base/process/launch_win.cc View 2 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
viettrungluu
6 years, 5 months ago (2014-07-26 00:06:27 UTC) #1
viettrungluu
6 years, 5 months ago (2014-07-26 00:06:33 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r285734.

Powered by Google App Engine
This is Rietveld 408576698