Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 411223002: Block on LaunchProcess failing on specific bot (Closed)

Created:
6 years, 5 months ago by scottmg
Modified:
6 years, 5 months ago
Reviewers:
brettw
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Block on LaunchProcess failing on specific bot Block in a loop if we get a specific failure on a particular bot. See environment variables at http://build.chromium.org/p/chromium.win/builders/Win8%20Aura/builds/20713/steps/views_unittests/logs/stdio for reference. Timeout raise attempted at https://codereview.chromium.org/410353004/ so that there will be time to attach a debugger. R=brettw@chromium.org BUG=340422 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285437

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M base/process/launch_win.cc View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scottmg
6 years, 5 months ago (2014-07-24 20:48:43 UTC) #1
brettw
Please remember to delete this code. LGTM
6 years, 5 months ago (2014-07-24 20:59:16 UTC) #2
scottmg
The CQ bit was checked by scottmg@chromium.org
6 years, 5 months ago (2014-07-24 21:15:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/411223002/1
6 years, 5 months ago (2014-07-24 21:16:01 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 00:31:55 UTC) #5
Message was sent while issue was closed. 
Change committed as 285437

Powered by Google App Engine
This is Rietveld 408576698