Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 414343003: Set default cross compiler for ARM/linux builds. (Closed)

Created:
6 years, 5 months ago by Sam Clegg
Modified:
6 years, 4 months ago
Reviewers:
Mark Seaborn, Nico, bradn
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Set default cross compiler for ARM/linux builds. Currently this relies on the user setting these variables outside of gyp and outside of source control. Once this lands the buildbot configs can be simplified to remove these variables. Even though we are trying to switch to clang by default in the short term, this is still useful for building with gcc on trusty (which has gcc 4.8), and allows us to simplify the bot configs. BUG=395832 R=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286219

Patch Set 1 #

Patch Set 2 : #

Total comments: 8

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M build/common.gypi View 1 2 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Sam Clegg
6 years, 5 months ago (2014-07-25 23:25:32 UTC) #1
Mark Seaborn
Can you set BUG=395832? The change looks OK to me, but common.gypi is quite hairy, ...
6 years, 4 months ago (2014-07-28 15:55:20 UTC) #2
Nico
https://codereview.chromium.org/414343003/diff/20001/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/414343003/diff/20001/build/common.gypi#newcode5590 build/common.gypi:5590: ['CC', '<(sysroot)/../bin/mipsel-linux-gnu-gcc'], On 2014/07/28 15:55:20, Mark Seaborn wrote: > ...
6 years, 4 months ago (2014-07-28 16:01:41 UTC) #3
Sam Clegg
https://codereview.chromium.org/414343003/diff/20001/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/414343003/diff/20001/build/common.gypi#newcode3390 build/common.gypi:3390: # Some sensible defaults for ARM cross compiling on ...
6 years, 4 months ago (2014-07-29 00:28:11 UTC) #4
Nico
lgtm
6 years, 4 months ago (2014-07-29 00:30:29 UTC) #5
Sam Clegg
6 years, 4 months ago (2014-07-29 16:52:52 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r286219 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698