Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 4143004: Disabling a number of failing chrome frame tests on Vista with IE7. Most of t... (Closed)

Created:
10 years, 1 month ago by ananta
Modified:
9 years, 6 months ago
Reviewers:
amit
CC:
chromium-reviews, amit
Visibility:
Public.

Description

Disabling a number of failing chrome frame tests on Vista with IE7. Most of these failures appear related to WebBrowser2::Navigate for the new window disposition opening up the popup in a new tab thus causing the tests to fail. A couple of failures are unrelated and need investigation. Bug=60987 TBR=amit Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64153

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -0 lines) Patch
M chrome_frame/test/navigation_test.cc View 1 4 chunks +24 lines, -0 lines 0 comments Download
M chrome_frame/test/test_with_web_server.cc View 1 1 chunk +15 lines, -0 lines 0 comments Download
M chrome_frame/test/ui_test.cc View 1 4 chunks +37 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ananta
10 years, 1 month ago (2010-10-27 21:34:17 UTC) #1
amit
10 years, 1 month ago (2010-10-28 00:23:07 UTC) #2
ok

On Wed, Oct 27, 2010 at 2:34 PM, <ananta@chromium.org> wrote:

> Reviewers: amit,
>
> Description:
> Disabling a number of failing chrome frame tests on Vista with IE7. Most of
> these failures
> appear related to WebBrowser2::Navigate for the new window disposition
> opening
> up the popup
> in a new tab thus causing the tests to fail. A couple of failures are
> unrelated
> and need
> investigation.
>
> Bug=60987
> TBR=amit
>
>
> Please review this at http://codereview.chromium.org/4143004/show
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     chrome_frame/test/navigation_test.cc
>  M     chrome_frame/test/test_with_web_server.cc
>  M     chrome_frame/test/ui_test.cc
>
>
>

Powered by Google App Engine
This is Rietveld 408576698