Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Side by Side Diff: chrome_frame/test/test_with_web_server.cc

Issue 4143004: Disabling a number of failing chrome frame tests on Vista with IE7. Most of t... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome_frame/test/navigation_test.cc ('k') | chrome_frame/test/ui_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome_frame/test/test_with_web_server.h" 5 #include "chrome_frame/test/test_with_web_server.h"
6 6
7 #include "base/base_paths.h" 7 #include "base/base_paths.h"
8 #include "base/file_version_info.h" 8 #include "base/file_version_info.h"
9 #include "base/path_service.h" 9 #include "base/path_service.h"
10 #include "base/stringprintf.h" 10 #include "base/stringprintf.h"
(...skipping 1004 matching lines...) Expand 10 before | Expand all | Expand 10 after
1015 L"xmlhttprequest_conditional_header_test.html"; 1015 L"xmlhttprequest_conditional_header_test.html";
1016 1016
1017 TEST_F(ChromeFrameTestWithWebServer, FullTabModeIE_XHRConditionalHeaderTest) { 1017 TEST_F(ChromeFrameTestWithWebServer, FullTabModeIE_XHRConditionalHeaderTest) {
1018 SimpleBrowserTest(IE, kXHRConditionalHeaderTestUrl); 1018 SimpleBrowserTest(IE, kXHRConditionalHeaderTestUrl);
1019 } 1019 }
1020 1020
1021 const wchar_t kWindowCloseTestUrl[] = 1021 const wchar_t kWindowCloseTestUrl[] =
1022 L"window_close.html"; 1022 L"window_close.html";
1023 1023
1024 TEST_F(ChromeFrameTestWithWebServer, FullTabModeIE_WindowClose) { 1024 TEST_F(ChromeFrameTestWithWebServer, FullTabModeIE_WindowClose) {
1025 // Please see http://code.google.com/p/chromium/issues/detail?id=60987
1026 // for more information on why this test is disabled for Vista with IE7.
1027 if (base::win::GetVersion() == base::win::VERSION_VISTA &&
1028 chrome_frame_test::GetInstalledIEVersion() == IE_7) {
1029 LOG(INFO) << "Not running test on Vista with IE7";
1030 return;
1031 }
1032
1025 SimpleBrowserTest(IE, kWindowCloseTestUrl); 1033 SimpleBrowserTest(IE, kWindowCloseTestUrl);
1026 } 1034 }
1027 1035
1028 TEST_F(ChromeFrameTestWithWebServer, FullTabModeFF_WindowClose) { 1036 TEST_F(ChromeFrameTestWithWebServer, FullTabModeFF_WindowClose) {
1037 // Please see http://code.google.com/p/chromium/issues/detail?id=60987
1038 // for more information on why this test is disabled for Vista with IE7.
1039 if (base::win::GetVersion() == base::win::VERSION_VISTA &&
1040 chrome_frame_test::GetInstalledIEVersion() == IE_7) {
1041 LOG(INFO) << "Not running test on Vista with IE7";
1042 return;
1043 }
1029 SimpleBrowserTest(FIREFOX, kWindowCloseTestUrl); 1044 SimpleBrowserTest(FIREFOX, kWindowCloseTestUrl);
1030 } 1045 }
1031 1046
1032 std::string GetHeaderValue(const std::string& headers, 1047 std::string GetHeaderValue(const std::string& headers,
1033 const char* header_name) { 1048 const char* header_name) {
1034 net::HttpUtil::HeadersIterator it(headers.begin(), headers.end(), 1049 net::HttpUtil::HeadersIterator it(headers.begin(), headers.end(),
1035 "\r\n"); 1050 "\r\n");
1036 while (it.GetNext()) { 1051 while (it.GetNext()) {
1037 if (lstrcmpiA(it.name().c_str(), header_name) == 0) { 1052 if (lstrcmpiA(it.name().c_str(), header_name) == 0) {
1038 return it.values(); 1053 return it.values();
(...skipping 207 matching lines...) Expand 10 before | Expand all | Expand 10 after
1246 1261
1247 std::wstring url(server.FormatHttpPath(L"form.html")); 1262 std::wstring url(server.FormatHttpPath(L"form.html"));
1248 1263
1249 ASSERT_TRUE(LaunchBrowser(IE, url.c_str())); 1264 ASSERT_TRUE(LaunchBrowser(IE, url.c_str()));
1250 loop_.RunFor(kChromeFrameLongNavigationTimeoutInSeconds); 1265 loop_.RunFor(kChromeFrameLongNavigationTimeoutInSeconds);
1251 1266
1252 EXPECT_EQ(1, response->get_request_count()); 1267 EXPECT_EQ(1, response->get_request_count());
1253 EXPECT_EQ(1, response->post_request_count()); 1268 EXPECT_EQ(1, response->post_request_count());
1254 } 1269 }
1255 1270
OLDNEW
« no previous file with comments | « chrome_frame/test/navigation_test.cc ('k') | chrome_frame/test/ui_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698