Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 414223009: Ignore command line args for record_wpr unit tests. (Closed)

Created:
6 years, 5 months ago by ariblue
Modified:
6 years, 5 months ago
Reviewers:
Dirk Pranke, dtu, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Ignore command line args for record_wpr unit tests. In record_wpr, _ParseArgs will take a list of arguments that can be provided by tests to be used instead (rather than being extra). BUG=397725 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285794

Patch Set 1 #

Patch Set 2 : git rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M tools/telemetry/telemetry/page/record_wpr.py View 1 3 chunks +5 lines, -7 lines 0 comments Download
M tools/telemetry/telemetry/page/record_wpr_unittest.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
ariblue
6 years, 5 months ago (2014-07-25 23:47:15 UTC) #1
tonyg
lgtm
6 years, 5 months ago (2014-07-25 23:57:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ariblue@google.com/414223009/1
6 years, 5 months ago (2014-07-25 23:59:59 UTC) #3
ariblue
The CQ bit was checked by ariblue@google.com
6 years, 5 months ago (2014-07-26 00:07:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ariblue@google.com/414223009/20001
6 years, 5 months ago (2014-07-26 00:10:20 UTC) #5
Dirk Pranke
looks like this should work to me as well. I will verify manually on Monday ...
6 years, 5 months ago (2014-07-26 16:32:56 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_gn_rel on tryserver.chromium.linux ...
6 years, 5 months ago (2014-07-26 18:10:00 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-26 19:49:35 UTC) #8
Message was sent while issue was closed.
Change committed as 285794

Powered by Google App Engine
This is Rietveld 408576698