Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Unified Diff: tools/telemetry/telemetry/page/record_wpr.py

Issue 414223009: Ignore command line args for record_wpr unit tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: git rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/page/record_wpr_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/page/record_wpr.py
diff --git a/tools/telemetry/telemetry/page/record_wpr.py b/tools/telemetry/telemetry/page/record_wpr.py
index 61df640ad1a7e13369684ab95ebd23f4e7f45648..c88df05518f3f5f2dced40aba8d93f29a0c5312f 100755
--- a/tools/telemetry/telemetry/page/record_wpr.py
+++ b/tools/telemetry/telemetry/page/record_wpr.py
@@ -114,7 +114,7 @@ def _MaybeGetInstanceOfClass(target, base_dir, cls):
class WprRecorder(object):
- def __init__(self, base_dir, target, extra_args=None):
+ def __init__(self, base_dir, target, args=None):
action_names_to_run = FindAllActionNames(base_dir)
self._record_page_test = RecorderPageTest(action_names_to_run)
self._options = self._CreateOptions()
@@ -125,7 +125,7 @@ class WprRecorder(object):
self._record_page_test.page_test = self._benchmark.test()
self._parser = self._options.CreateParser(usage='%prog <PageSet|Benchmark>')
self._AddCommandLineArgs()
- self._ParseArgs(extra_args)
+ self._ParseArgs(args)
self._ProcessCommandLineArgs()
self._page_set = self._GetPageSet(base_dir, target)
@@ -145,11 +145,9 @@ class WprRecorder(object):
self._benchmark.AddCommandLineArgs(self._parser)
self._benchmark.SetArgumentDefaults(self._parser)
- def _ParseArgs(self, extra_args=None):
- args = sys.argv[1:]
- if extra_args is not None:
- args += extra_args
- self._parser.parse_args(args)
+ def _ParseArgs(self, args=None):
+ args_to_parse = sys.argv[1:] if args is None else args
+ self._parser.parse_args(args_to_parse)
def _ProcessCommandLineArgs(self):
page_runner.ProcessCommandLineArgs(self._parser, self._options)
« no previous file with comments | « no previous file | tools/telemetry/telemetry/page/record_wpr_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698