Issue 413953002: Reuse GLES2Util code instead of defining new function in TextureManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 413953002: Reuse GLES2Util code instead of defining new function in TextureManager (Closed)

Created:
6 years, 5 months ago by hj.r.chung

Modified:
6 years, 5 months ago

Reviewers:
no sievers, piman

CC:
chromium-reviews, piman+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Reuse GLESUtil code instead of defining new function in TextureManager Use GLES2Util::IndexToGLFaceTarget instead of redefining in TextureManager and move GLTargetToFaceIndex to GLES2Util for possible future use. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285239

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+54 lines, -68 lines)			Patch
M	gpu/command_buffer/common/gles2_cmd_utils.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/common/gles2_cmd_utils.cc	View	1 chunk	+24 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/service/texture_manager.cc	View	12 chunks	+28 lines, -68 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

hj.r.chung

On 2014/07/24 04:27:35, piman (slow to review) wrote: > lgtm thanks!

6 years, 5 months ago (2014-07-24 04:28:26 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/heejin.r.chung@samsung.com/413953002/1

6 years, 5 months ago (2014-07-24 04:31:42 UTC) #5

Message was sent while issue was closed.

Change committed as 285239

Expand Messages | Collapse Messages