Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1079)

Unified Diff: Source/core/html/WindowNameCollection.cpp

Issue 413783002: Use isHTMLPlugInElement to replace checks (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Change more checks Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/dom/Element.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/WindowNameCollection.cpp
diff --git a/Source/core/html/WindowNameCollection.cpp b/Source/core/html/WindowNameCollection.cpp
index a229b05f15907189cd1258f35aef8c1e01dcdae4..a01accdf6e78e7977fd1ab8863101ddd2ee7e6d1 100644
--- a/Source/core/html/WindowNameCollection.cpp
+++ b/Source/core/html/WindowNameCollection.cpp
@@ -6,6 +6,7 @@
#include "core/html/WindowNameCollection.h"
#include "core/html/HTMLImageElement.h"
+#include "core/html/HTMLPlugInElement.h"
namespace blink {
@@ -20,9 +21,7 @@ bool WindowNameCollection::elementMatches(const Element& element) const
// but anything by id
if (isHTMLImageElement(element)
|| isHTMLFormElement(element)
- || isHTMLAppletElement(element)
Inactive 2014/07/23 21:21:14 Actually, I did not suggest this one because I pre
- || isHTMLEmbedElement(element)
- || isHTMLObjectElement(element)) {
+ || isHTMLPlugInElement(element)) {
if (element.getNameAttribute() == m_name)
return true;
}
« no previous file with comments | « Source/core/dom/Element.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698