Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Side by Side Diff: Source/core/html/WindowNameCollection.cpp

Issue 413783002: Use isHTMLPlugInElement to replace checks (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Change more checks Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/dom/Element.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "core/html/WindowNameCollection.h" 6 #include "core/html/WindowNameCollection.h"
7 7
8 #include "core/html/HTMLImageElement.h" 8 #include "core/html/HTMLImageElement.h"
9 #include "core/html/HTMLPlugInElement.h"
9 10
10 namespace blink { 11 namespace blink {
11 12
12 WindowNameCollection::WindowNameCollection(ContainerNode& document, const Atomic String& name) 13 WindowNameCollection::WindowNameCollection(ContainerNode& document, const Atomic String& name)
13 : HTMLNameCollection(document, WindowNamedItems, name) 14 : HTMLNameCollection(document, WindowNamedItems, name)
14 { 15 {
15 } 16 }
16 17
17 bool WindowNameCollection::elementMatches(const Element& element) const 18 bool WindowNameCollection::elementMatches(const Element& element) const
18 { 19 {
19 // Match only images, forms, applets, embeds and objects by name, 20 // Match only images, forms, applets, embeds and objects by name,
20 // but anything by id 21 // but anything by id
21 if (isHTMLImageElement(element) 22 if (isHTMLImageElement(element)
22 || isHTMLFormElement(element) 23 || isHTMLFormElement(element)
23 || isHTMLAppletElement(element) 24 || isHTMLPlugInElement(element)) {
Inactive 2014/07/23 21:21:14 Actually, I did not suggest this one because I pre
24 || isHTMLEmbedElement(element)
25 || isHTMLObjectElement(element)) {
26 if (element.getNameAttribute() == m_name) 25 if (element.getNameAttribute() == m_name)
27 return true; 26 return true;
28 } 27 }
29 return element.getIdAttribute() == m_name; 28 return element.getIdAttribute() == m_name;
30 } 29 }
31 30
32 } // namespace blink 31 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/dom/Element.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698