Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 413783002: Use isHTMLPlugInElement to replace checks (Closed)

Created:
6 years, 5 months ago by rwlbuis
Modified:
6 years, 5 months ago
Reviewers:
Inactive
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Use isHTMLPlugInElement to replace checks All the checked Elements (<object>, <embed>, <applet>) derive from HTMLPlugInElement and there is no other class deriving from it, so use isHTMLPlugInElement here instead. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178805

Patch Set 1 #

Patch Set 2 : Change more checks #

Total comments: 1

Patch Set 3 : Remove WindowNameCollection change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M Source/core/accessibility/AXNodeObject.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Element.cpp View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
rwlbuis
PTAL.
6 years, 5 months ago (2014-07-23 21:00:44 UTC) #1
Inactive
Can you take care of those in Source/core/accessibility/AXNodeObject.cpp as well?
6 years, 5 months ago (2014-07-23 21:05:10 UTC) #2
rwlbuis
On 2014/07/23 21:05:10, Chris Dumez wrote: > Can you take care of those in Source/core/accessibility/AXNodeObject.cpp ...
6 years, 5 months ago (2014-07-23 21:11:18 UTC) #3
rwlbuis
PTAL, I found even one more after a grep :)
6 years, 5 months ago (2014-07-23 21:15:51 UTC) #4
Inactive
https://codereview.chromium.org/413783002/diff/20001/Source/core/html/WindowNameCollection.cpp File Source/core/html/WindowNameCollection.cpp (left): https://codereview.chromium.org/413783002/diff/20001/Source/core/html/WindowNameCollection.cpp#oldcode23 Source/core/html/WindowNameCollection.cpp:23: || isHTMLAppletElement(element) Actually, I did not suggest this one ...
6 years, 5 months ago (2014-07-23 21:21:14 UTC) #5
rwlbuis
Ok I backed out the WindowNameCollection change.
6 years, 5 months ago (2014-07-23 21:28:34 UTC) #6
Inactive
On 2014/07/23 21:28:34, rwlbuis wrote: > Ok I backed out the WindowNameCollection change. Thanks, lgtm.
6 years, 5 months ago (2014-07-23 21:30:09 UTC) #7
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 5 months ago (2014-07-23 21:30:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/413783002/40001
6 years, 5 months ago (2014-07-23 21:31:26 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-24 04:21:36 UTC) #10
Message was sent while issue was closed.
Change committed as 178805

Powered by Google App Engine
This is Rietveld 408576698