Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 413733003: Bring back the retry limit to 3. (Closed)

Created:
6 years, 5 months ago by jam
Modified:
6 years, 5 months ago
Reviewers:
Sergey Berezin, brettw
CC:
chromium-reviews, w.bielawski
Project:
chromium
Visibility:
Public.

Description

Bring back the retry limit to 3. This reverts r284650. There is one test that is flaky 34% of the time, but that is the exception and not the norm. We don't need 12 retries to make browser_tests or other test suites not flaky. If there are very flaky tests, we should disable them instead. I've disabled all the tests that flake more than 5% of the time. BUG=395189 R=brettw@chromium.org, sergeyberezin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285006

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M base/test/launcher/test_launcher.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jam
6 years, 5 months ago (2014-07-23 16:15:22 UTC) #1
brettw
lgtm
6 years, 5 months ago (2014-07-23 16:28:55 UTC) #2
Sergey Berezin
LGTM. My stats don't show any noticeable difference in bot / step flakiness or runtime, ...
6 years, 5 months ago (2014-07-23 18:02:09 UTC) #3
jam
The CQ bit was checked by jam@chromium.org
6 years, 5 months ago (2014-07-23 18:40:27 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-23 18:41:56 UTC) #5

Powered by Google App Engine
This is Rietveld 408576698