Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Side by Side Diff: base/test/launcher/test_launcher.cc

Issue 413733003: Bring back the retry limit to 3. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/test/launcher/test_launcher.h" 5 #include "base/test/launcher/test_launcher.h"
6 6
7 #if defined(OS_POSIX) 7 #if defined(OS_POSIX)
8 #include <fcntl.h> 8 #include <fcntl.h>
9 #endif 9 #endif
10 10
(...skipping 325 matching lines...) Expand 10 before | Expand all | Expand 10 after
336 this, 336 this,
337 &TestLauncher::OnOutputTimeout), 337 &TestLauncher::OnOutputTimeout),
338 parallel_jobs_(parallel_jobs) { 338 parallel_jobs_(parallel_jobs) {
339 if (BotModeEnabled()) { 339 if (BotModeEnabled()) {
340 fprintf(stdout, 340 fprintf(stdout,
341 "Enabling defaults optimized for continuous integration bots.\n"); 341 "Enabling defaults optimized for continuous integration bots.\n");
342 fflush(stdout); 342 fflush(stdout);
343 343
344 // Enable test retries by default for bots. This can be still overridden 344 // Enable test retries by default for bots. This can be still overridden
345 // from command line using --test-launcher-retry-limit flag. 345 // from command line using --test-launcher-retry-limit flag.
346 // TODO(sergeyberezin): decrease retry_limit_ back to 3 when the 346 retry_limit_ = 3;
347 // ignorer_bot is deployed to automatically disable flaky tests.
348 retry_limit_ = 12;
349 } else { 347 } else {
350 // Default to serial test execution if not running on a bot. This makes it 348 // Default to serial test execution if not running on a bot. This makes it
351 // possible to disable stdio redirection and can still be overridden with 349 // possible to disable stdio redirection and can still be overridden with
352 // --test-launcher-jobs flag. 350 // --test-launcher-jobs flag.
353 parallel_jobs_ = 1; 351 parallel_jobs_ = 1;
354 } 352 }
355 } 353 }
356 354
357 TestLauncher::~TestLauncher() { 355 TestLauncher::~TestLauncher() {
358 if (worker_pool_owner_) 356 if (worker_pool_owner_)
(...skipping 732 matching lines...) Expand 10 before | Expand all | Expand 10 after
1091 1089
1092 g_live_processes.Get().erase(process_handle); 1090 g_live_processes.Get().erase(process_handle);
1093 } 1091 }
1094 1092
1095 base::CloseProcessHandle(process_handle); 1093 base::CloseProcessHandle(process_handle);
1096 1094
1097 return exit_code; 1095 return exit_code;
1098 } 1096 }
1099 1097
1100 } // namespace base 1098 } // namespace base
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698