Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Issue 41363002: Devirtualize several inspector classes destructors (Closed)

Created:
7 years, 2 months ago by Inactive
Modified:
7 years, 1 month ago
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Devirtualize several inspector classes destructors Devirtualize the following inspector classes destructors: DOMPatchSupport, InspectorHistory, InspectorState, InspectorStyle and ScriptProfile. This avoids creating unnecessary vtables since those classes are never subclasses nor do they have any virtual function. BUG=311561 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160575

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -13 lines) Patch
M Source/core/inspector/DOMPatchSupport.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/DOMPatchSupport.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorHistory.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorHistory.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorState.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorStyleSheet.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorStyleSheet.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/inspector/ScriptProfile.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Inactive
7 years, 2 months ago (2013-10-24 20:42:05 UTC) #1
pfeldman
lgtm, thanks.
7 years, 2 months ago (2013-10-25 10:56:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/41363002/1
7 years, 1 month ago (2013-10-25 13:18:51 UTC) #3
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
7 years, 1 month ago (2013-10-25 14:22:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/41363002/1
7 years, 1 month ago (2013-10-25 14:25:59 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-10-25 14:27:08 UTC) #6
Message was sent while issue was closed.
Change committed as 160575

Powered by Google App Engine
This is Rietveld 408576698