Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: Source/core/inspector/InspectorHistory.cpp

Issue 41363002: Devirtualize several inspector classes destructors (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/inspector/InspectorHistory.h ('k') | Source/core/inspector/InspectorState.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 { 76 {
77 return ""; 77 return "";
78 } 78 }
79 79
80 void InspectorHistory::Action::merge(PassOwnPtr<Action>) 80 void InspectorHistory::Action::merge(PassOwnPtr<Action>)
81 { 81 {
82 } 82 }
83 83
84 InspectorHistory::InspectorHistory() : m_afterLastActionIndex(0) { } 84 InspectorHistory::InspectorHistory() : m_afterLastActionIndex(0) { }
85 85
86 InspectorHistory::~InspectorHistory() { }
87
88 bool InspectorHistory::perform(PassOwnPtr<Action> action, ExceptionState& es) 86 bool InspectorHistory::perform(PassOwnPtr<Action> action, ExceptionState& es)
89 { 87 {
90 if (!action->perform(es)) 88 if (!action->perform(es))
91 return false; 89 return false;
92 90
93 if (!action->mergeId().isEmpty() && m_afterLastActionIndex > 0 && action->me rgeId() == m_history[m_afterLastActionIndex - 1]->mergeId()) 91 if (!action->mergeId().isEmpty() && m_afterLastActionIndex > 0 && action->me rgeId() == m_history[m_afterLastActionIndex - 1]->mergeId())
94 m_history[m_afterLastActionIndex - 1]->merge(action); 92 m_history[m_afterLastActionIndex - 1]->merge(action);
95 else { 93 else {
96 m_history.resize(m_afterLastActionIndex); 94 m_history.resize(m_afterLastActionIndex);
97 m_history.append(action); 95 m_history.append(action);
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
143 } 141 }
144 142
145 void InspectorHistory::reset() 143 void InspectorHistory::reset()
146 { 144 {
147 m_afterLastActionIndex = 0; 145 m_afterLastActionIndex = 0;
148 m_history.clear(); 146 m_history.clear();
149 } 147 }
150 148
151 } // namespace WebCore 149 } // namespace WebCore
152 150
OLDNEW
« no previous file with comments | « Source/core/inspector/InspectorHistory.h ('k') | Source/core/inspector/InspectorState.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698