content: Remove RendererPreferences font-rendering enums.

content/public/common/renderer_preferences.cc

Index: content/public/common/renderer_preferences.cc
diff --git a/content/public/common/renderer_preferences.cc b/content/public/common/renderer_preferences.cc
index 1e4c6d55ec82770d0839efd0d992a732d91fc263..b55cbdded1b9ab74b5514ab95f3b57964d1dcd57 100644
--- a/content/public/common/renderer_preferences.cc
+++ b/content/public/common/renderer_preferences.cc
@@ -5,6 +5,7 @@
 #include "content/public/common/renderer_preferences.h"
 
 #include "third_party/skia/include/core/SkColor.h"
+#include "ui/gfx/font_render_params.h"
 
 namespace {
 // The touchpad / touchscreen fling profiles are a matched set
@@ -21,11 +22,10 @@ namespace content {
 RendererPreferences::RendererPreferences()
     : can_accept_load_drops(true),
       should_antialias_text(true),
-      hinting(RENDERER_PREFERENCES_HINTING_SYSTEM_DEFAULT),
+      hinting(gfx::FontRenderParams::HINTING_SLIGHT),

[msw, 2014/07/22 20:58:35]

RendererPreferencesToSkiaHinting used Normal for default previously, is this
change to use slight okay?

[Daniel Erat, 2014/07/22 21:15:50]

i believe that the default value is arbitrary since this struct is later
initialized to the values from gfx::GetDefaultWebKitFontRenderParams(). matching
FontRenderParam's defaults (as i'm doing here) seems cleaner, though.

[msw, 2014/07/22 21:45:07]

Acknowledged.

       use_autohinter(false),
       use_bitmaps(false),
-      subpixel_rendering(
-          RENDERER_PREFERENCES_SUBPIXEL_RENDERING_SYSTEM_DEFAULT),
+      subpixel_rendering(gfx::FontRenderParams::SUBPIXEL_RENDERING_RGB),

[msw, 2014/07/22 20:58:35]

Doesn't this conflict with the old behavior of
RendererPreferencesToSubpixelRenderingFlag and Behdad's advice:
https://codereview.chromium.org/407763003/#msg11

[Daniel Erat, 2014/07/22 21:15:50]

this one also gets reset later. i'm fine with switching it to _NONE here, but i
don't think it really matters.

[msw, 2014/07/22 21:45:07]

I guess it doesn't really matter if both here and the FontRenderParams ctor
default values should always be overwritten. But maybe both should be *_NONE
just to be safe, given Behdad's advice.

[Daniel Erat, 2014/07/23 00:10:23]

done

       use_subpixel_positioning(false),
       focus_ring_color(SkColorSetARGB(255, 229, 151, 0)),
       thumb_active_color(SkColorSetRGB(244, 244, 244)),