content: Remove RendererPreferences font-rendering enums.

content/public/common/renderer_preferences.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/common/renderer_preferences.h"
 
 #include "third_party/skia/include/core/SkColor.h"
+#include "ui/gfx/font_render_params.h"
 
 namespace {
 // The touchpad / touchscreen fling profiles are a matched set
 // determined via UX experimentation. Do not modify without
 // first discussing with rjkroege@chromium.org or
 // wjmaclean@chromium.org.
 const float kDefaultAlpha = -5.70762e+03f;
 const float kDefaultBeta = 1.72e+02f;
 const float kDefaultGamma = 3.7e+00f;
 }
 
 namespace content {
 
 RendererPreferences::RendererPreferences()
     : can_accept_load_drops(true),
       should_antialias_text(true),
-      hinting(RENDERER_PREFERENCES_HINTING_SYSTEM_DEFAULT),
+      hinting(gfx::FontRenderParams::HINTING_SLIGHT),

[msw, 2014/07/22 20:58:35]

RendererPreferencesToSkiaHinting used Normal for default previously, is this
change to use slight okay?

[Daniel Erat, 2014/07/22 21:15:50]

i believe that the default value is arbitrary since this struct is later
initialized to the values from gfx::GetDefaultWebKitFontRenderParams(). matching
FontRenderParam's defaults (as i'm doing here) seems cleaner, though.

[msw, 2014/07/22 21:45:07]

Acknowledged.

       use_autohinter(false),
       use_bitmaps(false),
-      subpixel_rendering(
-          RENDERER_PREFERENCES_SUBPIXEL_RENDERING_SYSTEM_DEFAULT),
+      subpixel_rendering(gfx::FontRenderParams::SUBPIXEL_RENDERING_RGB),

[msw, 2014/07/22 20:58:35]

Doesn't this conflict with the old behavior of
RendererPreferencesToSubpixelRenderingFlag and Behdad's advice:
https://codereview.chromium.org/407763003/#msg11

[Daniel Erat, 2014/07/22 21:15:50]

this one also gets reset later. i'm fine with switching it to _NONE here, but i
don't think it really matters.

[msw, 2014/07/22 21:45:07]

I guess it doesn't really matter if both here and the FontRenderParams ctor
default values should always be overwritten. But maybe both should be *_NONE
just to be safe, given Behdad's advice.

[Daniel Erat, 2014/07/23 00:10:23]

done

       use_subpixel_positioning(false),
       focus_ring_color(SkColorSetARGB(255, 229, 151, 0)),
       thumb_active_color(SkColorSetRGB(244, 244, 244)),
       thumb_inactive_color(SkColorSetRGB(234, 234, 234)),
       track_color(SkColorSetRGB(211, 211, 211)),
       active_selection_bg_color(SkColorSetRGB(30, 144, 255)),
       active_selection_fg_color(SK_ColorWHITE),
       inactive_selection_bg_color(SkColorSetRGB(200, 200, 200)),
       inactive_selection_fg_color(SkColorSetRGB(50, 50, 50)),
       browser_handles_non_local_top_level_requests(false),
@@ skipping 12 matching lines @@
       use_video_overlay_for_embedded_encrypted_video(false) {
   touchpad_fling_profile[0] = kDefaultAlpha;
   touchpad_fling_profile[1] = kDefaultBeta;
   touchpad_fling_profile[2] = kDefaultGamma;
   touchscreen_fling_profile = touchpad_fling_profile;
 }
 
 RendererPreferences::~RendererPreferences() { }
 
 }  // namespace content